Summary: | Compute number of PAC bits from what the OS says its address space is | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Keith Miller <keith_miller> | ||||||
Component: | New Bugs | Assignee: | Keith Miller <keith_miller> | ||||||
Status: | REOPENED --- | ||||||||
Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, commit-queue, ews-watchlist, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 215065 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Keith Miller
2020-07-30 13:41:36 PDT
Created attachment 405609 [details]
Patch
Comment on attachment 405609 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405609&action=review > Source/WTF/wtf/PtrTag.h:34 > +#if CPU(ARM64E) && __has_include(<mach/arm/vm_param.h>) I feel like this should be DARWIN based, w/ an assert we have the header Comment on attachment 405609 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405609&action=review > Source/WTF/wtf/PtrTag.h:36 > +constexpr unsigned maximumNumberOfPointerAuthenticationBits = 64 - getMSBSetConstexpr(MACH_VM_MAX_ADDRESS_RAW); is this off by 1? I suggested to Keith to just do 64 - OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH) Created attachment 405622 [details]
Patch for landing
(In reply to Saam Barati from comment #4) > I suggested to Keith to just do 64 - OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH) Done. Committed r265113: <https://trac.webkit.org/changeset/265113> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405622 [details]. This change broke the Windows build, as EWS predicted: C:\cygwin\worker\win10-release\build\WebKitBuild\Release\DerivedSources\ForwardingHeaders\wtf/CagedPtr.h(43,1): error C2220: the following warning is treated as an error [C:\cygwin\worker\win10-release\build\WebKitBuild\Release\Source\JavaScriptCore\LLIntOffsetsExtractor.vcxproj] C:\cygwin\worker\win10-release\build\Source\JavaScriptCore\runtime\ArrayBuffer.h(61): message : see reference to class template instantiation 'WTF::CagedPtr<Gigacage::Primitive,void,true,WTF::DumbPtrTraits<T>>' being compiled [C:\cygwin\worker\win10-release\build\WebKitBuild\Release\Source\JavaScriptCore\LLIntOffsetsExtractor.vcxproj] C:\cygwin\worker\win10-release\build\Source\JavaScriptCore\runtime\ArrayBuffer.h(61): message : with [C:\cygwin\worker\win10-release\build\WebKitBuild\Release\Source\JavaScriptCore\LLIntOffsetsExtractor.vcxproj] C:\cygwin\worker\win10-release\build\Source\JavaScriptCore\runtime\ArrayBuffer.h(61): message : [ [C:\cygwin\worker\win10-release\build\WebKitBuild\Release\Source\JavaScriptCore\LLIntOffsetsExtractor.vcxproj] C:\cygwin\worker\win10-release\build\Source\JavaScriptCore\runtime\ArrayBuffer.h(61): message : T=void [C:\cygwin\worker\win10-release\build\WebKitBuild\Release\Source\JavaScriptCore\LLIntOffsetsExtractor.vcxproj] C:\cygwin\worker\win10-release\build\Source\JavaScriptCore\runtime\ArrayBuffer.h(61): message : ] [C:\cygwin\worker\win10-release\build\WebKitBuild\Release\Source\JavaScriptCore\LLIntOffsetsExtractor.vcxproj] (In reply to Ryan Haddad from comment #9) > This change broke the Windows build, as EWS predicted: > C:\cygwin\worker\win10- > release\build\WebKitBuild\Release\DerivedSources\ForwardingHeaders\wtf/ > CagedPtr.h(43,1): error C2220: the following warning is treated as an error > [C:\cygwin\worker\win10- > release\build\WebKitBuild\Release\Source\JavaScriptCore\LLIntOffsetsExtractor > .vcxproj] > C:\cygwin\worker\win10- > release\build\Source\JavaScriptCore\runtime\ArrayBuffer.h(61): message : see > reference to class template instantiation > 'WTF::CagedPtr<Gigacage::Primitive,void,true,WTF::DumbPtrTraits<T>>' being > compiled > [C:\cygwin\worker\win10- > release\build\WebKitBuild\Release\Source\JavaScriptCore\LLIntOffsetsExtractor > .vcxproj] > C:\cygwin\worker\win10- > release\build\Source\JavaScriptCore\runtime\ArrayBuffer.h(61): message : > with > [C:\cygwin\worker\win10- > release\build\WebKitBuild\Release\Source\JavaScriptCore\LLIntOffsetsExtractor > .vcxproj] > C:\cygwin\worker\win10- > release\build\Source\JavaScriptCore\runtime\ArrayBuffer.h(61): message : > [ > [C:\cygwin\worker\win10- > release\build\WebKitBuild\Release\Source\JavaScriptCore\LLIntOffsetsExtractor > .vcxproj] > C:\cygwin\worker\win10- > release\build\Source\JavaScriptCore\runtime\ArrayBuffer.h(61): message : > T=void > [C:\cygwin\worker\win10- > release\build\WebKitBuild\Release\Source\JavaScriptCore\LLIntOffsetsExtractor > .vcxproj] > C:\cygwin\worker\win10- > release\build\Source\JavaScriptCore\runtime\ArrayBuffer.h(61): message : > ] > [C:\cygwin\worker\win10- > release\build\WebKitBuild\Release\Source\JavaScriptCore\LLIntOffsetsExtractor > .vcxproj] Should be fixed with r265122. Re-opened since this is blocked by bug 215065 |