Bug 214984

Summary: [iPadOS] Two taps are required to choose a country/region when creating an account on ea.com
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: FormsAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, hi, megan_gardner, pxlcoder, thorton, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Wenson Hsieh 2020-07-30 13:16:36 PDT 
<rdar://problem/66261490>
Comment 1 Wenson Hsieh 2020-07-30 14:05:48 PDT 
Created attachment 405613 [details]
Patch
Comment 2 Devin Rousso 2020-07-30 14:35:27 PDT 
Comment on attachment 405613 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405613&action=review

r=me

> Source/WebKit/UIProcess/ios/forms/WKFormPopover.mm:141
> +        auto scale = [_view page]->pageScaleFactor();

`_view.page`?

> LayoutTests/fast/forms/ios/repeatedly-focus-offscreen-select.html:25
> +jsTestIsAsync = true;

NIT: `window.jsTestIsAsync = true;`

> LayoutTests/fast/forms/ios/repeatedly-focus-offscreen-select.html:26
> +clickCount = 0;

NIT: `let`

> LayoutTests/fast/forms/ios/repeatedly-focus-offscreen-select.html:28
> +addEventListener("load", async () => {

NIT: `window.addEventListener` or `document.addEventListener`?  I'd put one just to be clear.

> LayoutTests/fast/forms/ios/repeatedly-focus-offscreen-select.html:36
> +    button = document.querySelector("button");

NIT: `let`

> LayoutTests/fast/forms/ios/repeatedly-focus-offscreen-select.html:37
> +    select = document.querySelector("select");

NIT: `let`
Comment 3 Wenson Hsieh 2020-07-30 14:46:26 PDT 
Comment on attachment 405613 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405613&action=review

>> Source/WebKit/UIProcess/ios/forms/WKFormPopover.mm:141
>> +        auto scale = [_view page]->pageScaleFactor();
> 
> `_view.page`?

👍🏻

>> LayoutTests/fast/forms/ios/repeatedly-focus-offscreen-select.html:25
>> +jsTestIsAsync = true;
> 
> NIT: `window.jsTestIsAsync = true;`

👍🏻

>> LayoutTests/fast/forms/ios/repeatedly-focus-offscreen-select.html:26
>> +clickCount = 0;
> 
> NIT: `let`

👍🏻

>> LayoutTests/fast/forms/ios/repeatedly-focus-offscreen-select.html:28
>> +addEventListener("load", async () => {
> 
> NIT: `window.addEventListener` or `document.addEventListener`?  I'd put one just to be clear.

Changed to window.addEventListener!

>> LayoutTests/fast/forms/ios/repeatedly-focus-offscreen-select.html:36
>> +    button = document.querySelector("button");
> 
> NIT: `let`

👍🏻

>> LayoutTests/fast/forms/ios/repeatedly-focus-offscreen-select.html:37
>> +    select = document.querySelector("select");
> 
> NIT: `let`

👍🏻
Comment 4 Wenson Hsieh 2020-07-30 14:53:00 PDT 
Created attachment 405625 [details]
Patch for landing
Comment 5 EWS 2020-07-30 16:32:04 PDT 
Committed r265117: <https://trac.webkit.org/changeset/265117>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405625 [details].