Bug 214984 – [iPadOS] Two taps are required to choose a country/region when creating an account on ea.com

• Component: Forms
• Status: RESOLVED FIXED

[Wenson Hsieh]

<rdar://problem/66261490>

[Wenson Hsieh]

Created attachment 405613 [details]
Patch

[Devin Rousso]

Comment on attachment 405613 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405613&action=review

r=me

> Source/WebKit/UIProcess/ios/forms/WKFormPopover.mm:141
> +        auto scale = [_view page]->pageScaleFactor();

`_view.page`?

> LayoutTests/fast/forms/ios/repeatedly-focus-offscreen-select.html:25
> +jsTestIsAsync = true;

NIT: `window.jsTestIsAsync = true;`

> LayoutTests/fast/forms/ios/repeatedly-focus-offscreen-select.html:26
> +clickCount = 0;

NIT: `let`

> LayoutTests/fast/forms/ios/repeatedly-focus-offscreen-select.html:28
> +addEventListener("load", async () => {

NIT: `window.addEventListener` or `document.addEventListener`?  I'd put one just to be clear.

> LayoutTests/fast/forms/ios/repeatedly-focus-offscreen-select.html:36
> +    button = document.querySelector("button");

NIT: `let`

> LayoutTests/fast/forms/ios/repeatedly-focus-offscreen-select.html:37
> +    select = document.querySelector("select");

NIT: `let`

[Wenson Hsieh]

Comment on attachment 405613 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405613&action=review

>> Source/WebKit/UIProcess/ios/forms/WKFormPopover.mm:141
>> +        auto scale = [_view page]->pageScaleFactor();
> 
> `_view.page`?

👍🏻

>> LayoutTests/fast/forms/ios/repeatedly-focus-offscreen-select.html:25
>> +jsTestIsAsync = true;
> 
> NIT: `window.jsTestIsAsync = true;`

👍🏻

>> LayoutTests/fast/forms/ios/repeatedly-focus-offscreen-select.html:26
>> +clickCount = 0;
> 
> NIT: `let`

👍🏻

>> LayoutTests/fast/forms/ios/repeatedly-focus-offscreen-select.html:28
>> +addEventListener("load", async () => {
> 
> NIT: `window.addEventListener` or `document.addEventListener`?  I'd put one just to be clear.

Changed to window.addEventListener!

>> LayoutTests/fast/forms/ios/repeatedly-focus-offscreen-select.html:36
>> +    button = document.querySelector("button");
> 
> NIT: `let`

👍🏻

>> LayoutTests/fast/forms/ios/repeatedly-focus-offscreen-select.html:37
>> +    select = document.querySelector("select");
> 
> NIT: `let`

👍🏻

[Wenson Hsieh]

Created attachment 405625 [details]
Patch for landing

[EWS]

Committed r265117: <https://trac.webkit.org/changeset/265117>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405625 [details].