Bug 214983

Summary:

webkitpy: If LC_ALL is set to a empty string, svn doesn't use the password store

Product:

WebKit

Reporter:

Fujii Hironori <Hironori.Fujii>

Component:

Tools / Tests

Assignee:

Fujii Hironori <Hironori.Fujii>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, ddkilzer, ews-watchlist, glenn, jbedard, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=259640

Attachments:

Description	Flags
Patch	darin: review+

Description Fujii Hironori 2020-07-30 12:57:19 PDT

If LC_ALL is set to a empty string, svn doesn't use the password store in my environment.

I'm using svn with gpg-agent on Ubuntu 20.04
svn version 1.13.0 (r1867053)
gpg-agent (GnuPG) 2.2.19

r101274 (Bug 68691) has set LC_ALL to a empty string.

If I invoke 'svn ci' on terminal, svn askes gpg-agent my password as expected,
but if I invoke 'LC_ALL= svn ci', svn askes my password by itself.

Comment 1 Fujii Hironori 2020-07-30 13:08:17 PDT

Created attachment 405601 [details]
Patch

Comment 2 Darin Adler 2020-07-30 13:50:40 PDT

Comment on attachment 405601 [details]
Patch

Looks great to me, but I am not sure why we had it set to empty string before.

Comment 3 Fujii Hironori 2020-07-30 18:14:29 PDT

Committed r265124: <https://trac.webkit.org/changeset/265124>

Comment 4 Radar WebKit Bug Importer 2020-07-30 18:15:29 PDT

<rdar://problem/66357693>

Comment 5 Fujii Hironori 2020-07-30 18:19:16 PDT

Thank you for the review. I don't know the reason.

ios-wk2 testing EWS bot is sick today. Apple devs are working on <rdar://problem/58089873>.