Summary: | REGRESSION (r?): Web Inspector: Timelines: blue border below selected timeline when in edit mode | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||
Component: | Web Inspector | Assignee: | Nikita Vasilyev <nvasilyev> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | hi, inspector-bugzilla-changes, jonlee, nvasilyev, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Devin Rousso
2020-07-30 11:26:40 PDT
It's coming from this rule: body:not(.window-inactive, .window-docked-inactive) .timeline-overview > .tree-outline.timelines:focus-within .item.selected + .item { border-top-color: hsl(209, 100%, 49%); } The CSS rule was added in 2016: https://trac.webkit.org/changeset/197473/webkit I don't know why we need it now (haven't looked deeply into the issue though). Was this an intentional design decision that we should now reconsider? Or is this a regression? First of all, this isn't a recent regression. I assume that, 4 years ago, Matt wanted to style the border of selected item with slightly lighter color than the selection color. That predated custom accent colors. I don't think we should do this (change border color) anymore. (In reply to Nikita Vasilyev from comment #5) > First of all, this isn't a recent regression. > > I assume that, 4 years ago, Matt wanted to style the border of selected item with slightly lighter color than the selection color. That predated custom accent colors. I don't think we should do this (change border color) anymore. This is not true. I am not able to reproduce this using Safari 13.1.1 (15609.2.9.1.2). I'm not able to even select timelines when in Edit mode. Okay, I'm going to remove this colored border now. It doesn't match the accent color — when the accent color is yellow the border is still blue. Created attachment 405642 [details]
Patch
Created attachment 405643 [details]
[Video] With patch applied
Comment on attachment 405642 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405642&action=review r=me, nice! > Source/WebInspectorUI/UserInterface/Views/TimelineOverview.css:115 > .timeline-overview > .tree-outline.timelines .item:not(.selected):not(:first-child) { It's odd to me that the `border-top` doesn't also apply when `.selected`, as right now there's basically no border between the selected item and the item above it, while there is a border between the selected item and the item below it. I think we should also have the `border-top` set when `.selected`. Created attachment 405649 [details]
Patch
Committed r265125: <https://trac.webkit.org/changeset/265125> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405649 [details]. |