Bug 214951

Summary: [webkitpy] Use webkitcorepy's auto installer for requests
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, dewei_zhu, ews-watchlist, glenn, slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=214950
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch jbedard: commit-queue-

Jonathan Bedard
Reported 2020-07-29 17:26:45 PDT
webkitcorepy has an auto-installed version of the requests library, we should be using that.
Attachments
Patch (9.04 KB, patch)
2020-07-29 21:29 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (9.09 KB, patch)
2020-07-29 21:40 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (9.84 KB, patch)
2020-07-30 07:17 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (9.87 KB, patch)
2020-07-30 21:01 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (6.93 KB, patch)
2020-08-04 16:02 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (8.08 KB, patch)
2020-08-04 16:27 PDT, Jonathan Bedard 		jbedard: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-07-29 20:46:42 PDT
<rdar://problem/66308049>
Jonathan Bedard
Comment 2 2020-07-29 21:29:23 PDT
Created attachment 405545 [details] Patch
Jonathan Bedard
Comment 3 2020-07-29 21:34:38 PDT
Comment on attachment 405545 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405545&action=review > Tools/Scripts/webkitpy/thirdparty/__init__.py:86 > + sys.path.insert(1 if 'libraries/autoinstalled' in sys.path[0] else 0, _AUTOINSTALLED_DIR) Needed for compatibility. webkitpy cannot override webkitcorepy since webkitcorepy is, in some cases, uses more updated versions of the auto-installed libraries. We also don't want to require existing checkouts to delete their webkitpy auto install directory.
Jonathan Bedard
Comment 4 2020-07-29 21:40:41 PDT
Created attachment 405546 [details] Patch
Jonathan Bedard
Comment 5 2020-07-30 07:17:24 PDT
Created attachment 405568 [details] Patch
Jonathan Bedard
Comment 6 2020-07-30 21:01:26 PDT
Created attachment 405659 [details] Patch
Jonathan Bedard
Comment 7 2020-08-01 21:04:10 PDT
Comment on attachment 405659 [details] Patch Blocking this on <https://bugs.webkit.org/show_bug.cgi?id=215067>, since that problem more correctly solves some of the issues this patch attempts to.
Jonathan Bedard
Comment 8 2020-08-04 16:02:14 PDT
Created attachment 405954 [details] Patch
Jonathan Bedard
Comment 9 2020-08-04 16:27:57 PDT
Created attachment 405962 [details] Patch
EWS
Comment 10 2020-08-12 16:10:14 PDT
Committed r265574: <https://trac.webkit.org/changeset/265574> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405954 [details].
Note You need to log in before you can comment on or make changes to this bug.