Summary: | [ews.webkit.org] Skip build upload for embedded iOS builds | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||||
Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | aakash_jain, ap, ews-watchlist, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Jonathan Bedard
2020-07-29 09:39:56 PDT
Created attachment 405466 [details]
Patch
Created attachment 405468 [details]
Patch
Comment on attachment 405468 [details]
Patch
would be good to add a unit-test as well in factories_unittest.py::TestBuildFactory similar to test_ios_build_factory
Created attachment 405493 [details]
Patch
Committed r265053: <https://trac.webkit.org/changeset/265053> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405493 [details]. Restarted buildbot to pick up this change. Working fine, e.g.: https://ews-build.webkit.org/#/builders/22/builds/24146 Comment on attachment 405493 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405493&action=review > Tools/BuildSlaveSupport/ews-build/config.json:359 > + "factory": "iOSEmbeddedBuildFactory", I think better name would be iOSBuildOnlyFactory, similar to https://bugs.webkit.org/attachment.cgi?id=405531&action=prettypatch We should rename it to have consistency. |