Bug 214923

Summary: [ews.webkit.org] Skip build upload for embedded iOS builds
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Jonathan Bedard
Reported 2020-07-29 09:39:56 PDT
We don't need embedded iOS builds to be uploaded, and uploading builds takes ~2 minutes.
Attachments
Patch (1.76 KB, patch)
2020-07-29 09:45 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (2.77 KB, patch)
2020-07-29 09:50 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (5.13 KB, patch)
2020-07-29 13:33 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2020-07-29 09:45:13 PDT
Created attachment 405466 [details] Patch
Jonathan Bedard
Comment 2 2020-07-29 09:50:30 PDT
Created attachment 405468 [details] Patch
Aakash Jain
Comment 3 2020-07-29 10:06:28 PDT
Comment on attachment 405468 [details] Patch would be good to add a unit-test as well in factories_unittest.py::TestBuildFactory similar to test_ios_build_factory
Jonathan Bedard
Comment 4 2020-07-29 13:33:10 PDT
Created attachment 405493 [details] Patch
EWS
Comment 5 2020-07-29 14:02:55 PDT
Committed r265053: <https://trac.webkit.org/changeset/265053> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405493 [details].
Radar WebKit Bug Importer
Comment 6 2020-07-29 14:03:18 PDT
<rdar://problem/66291195>
Aakash Jain
Comment 7 2020-07-30 06:04:18 PDT
Restarted buildbot to pick up this change. Working fine, e.g.: https://ews-build.webkit.org/#/builders/22/builds/24146
Aakash Jain
Comment 8 2020-07-30 08:37:29 PDT
Comment on attachment 405493 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405493&action=review > Tools/BuildSlaveSupport/ews-build/config.json:359 > + "factory": "iOSEmbeddedBuildFactory", I think better name would be iOSBuildOnlyFactory, similar to https://bugs.webkit.org/attachment.cgi?id=405531&action=prettypatch We should rename it to have consistency.
Note You need to log in before you can comment on or make changes to this bug.