Bug 214923

Summary: [ews.webkit.org] Skip build upload for embedded iOS builds
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Jonathan Bedard 2020-07-29 09:39:56 PDT
We don't need embedded iOS builds to be uploaded, and uploading builds takes ~2 minutes.
Comment 1 Jonathan Bedard 2020-07-29 09:45:13 PDT
Created attachment 405466 [details]
Patch
Comment 2 Jonathan Bedard 2020-07-29 09:50:30 PDT
Created attachment 405468 [details]
Patch
Comment 3 Aakash Jain 2020-07-29 10:06:28 PDT
Comment on attachment 405468 [details]
Patch

would be good to add a unit-test as well in factories_unittest.py::TestBuildFactory similar to test_ios_build_factory
Comment 4 Jonathan Bedard 2020-07-29 13:33:10 PDT
Created attachment 405493 [details]
Patch
Comment 5 EWS 2020-07-29 14:02:55 PDT
Committed r265053: <https://trac.webkit.org/changeset/265053>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405493 [details].
Comment 6 Radar WebKit Bug Importer 2020-07-29 14:03:18 PDT
<rdar://problem/66291195>
Comment 7 Aakash Jain 2020-07-30 06:04:18 PDT
Restarted buildbot to pick up this change.
Working fine, e.g.: https://ews-build.webkit.org/#/builders/22/builds/24146
Comment 8 Aakash Jain 2020-07-30 08:37:29 PDT
Comment on attachment 405493 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405493&action=review

> Tools/BuildSlaveSupport/ews-build/config.json:359
> +      "factory": "iOSEmbeddedBuildFactory",

I think better name would be iOSBuildOnlyFactory, similar to https://bugs.webkit.org/attachment.cgi?id=405531&action=prettypatch
We should rename it to have consistency.