Bug 21492

Summary:

[Cairo] Synthetic Bold/Oblique not working with cairo

Product:

WebKit

Reporter:

Alexander Macdonald <alexmac>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Major

CC:

alexmac, alp, bfulgham, emacemac7

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

OS X 10.5

Attachments:

Description	Flags
patch for synthetic font support in cairo	none
patch for synthetic font support with cairo	darin: review+

Alexander Macdonald

Reported 2008-10-08 18:01:52 PDT

The cairo port of webkit renders synthetic bold/oblique fonts as normal. This is not a bug, just a lack of implementation caused when the font handling code was reorganised sometime back in June. The attached patch contains the cairo implementation for this feature

Attachments
patch for synthetic font support in cairo (2.64 KB, patch) 2008-10-08 18:02 PDT, Alexander Macdonald	no flags	Details Formatted Diff Diff
patch for synthetic font support with cairo (5.35 KB, patch) 2008-10-13 15:42 PDT, Alexander Macdonald	darin: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Alexander Macdonald

Comment 1 2008-10-08 18:02:58 PDT

Created attachment 24211 [details] patch for synthetic font support in cairo

Alexander Macdonald

Comment 2 2008-10-08 18:12:01 PDT

Simple testcase: <html> 赤と黒、4つのマーク、13の数字 赤と黒、4つのマーク、13の数字 赤と黒、4つのマーク、13の数字 </html>

Alp Toker

Comment 3 2008-10-09 20:40:13 PDT

(In reply to comment #1) > Created an attachment (id=24211) [edit] > patch for synthetic font support in cairo > Hi Alex, Please mark your patch r? if you want review. You should fix up coding style (spaces, not tabs) and include a ChangeLog entry too (exact procedure is described on webkit.org). Thanks

Alexander Macdonald

Comment 4 2008-10-13 15:42:52 PDT

Created attachment 24329 [details] patch for synthetic font support with cairo

Alexander Macdonald

Comment 5 2008-10-13 15:44:41 PDT

Oops, sorry about that, I've attached a better patch that conforms to the webkit guidelines.

Eric Seidel (no email)

Comment 6 2008-10-21 14:39:04 PDT

Comment on attachment 24329 [details] patch for synthetic font support with cairo Style error: else { 63 cairo_translate(cr, point.x(), point.y()); 64 } But mitz should probably review this.

Eric Seidel (no email)

Comment 7 2009-05-22 07:40:55 PDT

Comment on attachment 24329 [details] patch for synthetic font support with cairo WebKit prefers const values to #defines: +#define SYNTHETIC_OBLIQUE_ANGLE 14 This is what pixel tests were made for. It saddens me that gtk still doesn't have pixel tests.

Darin Adler

Comment 8 2009-05-23 13:17:51 PDT

Comment on attachment 24329 [details] patch for synthetic font support with cairo > + if(font->platformData().syntheticOblique()) { Need a space after the "if" here. Everything else looks OK, although the technique of drawing the text twice isn't the best known synthetic bold technique. r=me

Brent Fulgham

Comment 9 2009-05-29 12:54:05 PDT

A really great change -- works wonderfully under Windows! Landed in @r44268.

Brent Fulgham

Comment 10 2009-07-16 09:07:58 PDT

*** Bug 26120 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.