Bug 21491
| Summary: | LayoutTests/transitions/opacity-transition-zindex.html is timing sensitive | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tony Chang <tony> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cmarrin, simon.fraser |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Tony Chang
LayoutTests/transitions/opacity-transition-zindex.html runs a CSS animation with a duration of 5 seconds. The test finishes (calls layoutTestController.notifyDone()) after 2.5 seconds. This makes it impossible for there to be a pixel result for the test since dumping the pixel results happens during the middle of the transition. On Chromium, we run pixel tests with every run, so it's not possible for us to pass this test.
Would the test still be valid if we changed it to use layoutTestController.dumpAsText()? We could get the z-indexes with some javascript.
Also, 2.5s for a single layout test seems way too long.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Simon Fraser (smfr)
I would like to see the render tree for this test. Maybe we should just make everything visibility:hidden at the end?
Tony Chang
Changing what happens at the end of the test (after 5s) doesn't help.
To clarify, the problem with dumping the pixel results during the middle of the css transition is that the exact image that gets dumped varies depending on the speed of the computer. It doesn't seem like it's possible to dump the render tree and not grab a pixel dump (or have them dumped at different times).
Simon Fraser (smfr)
Yeah, what we really need is a test-only API to freeze transitions.
Another "solution" here would be to give rgba(, , , 0) colors to everything. Suck.
Simon Fraser (smfr)
Test now uses the 'pauseTransitionAtTimeOnElementWithId' API.