Bug 214901

Summary: WebAssembly validation for call_indirect is incorrect
Product: WebKit Reporter: Tadeu Zagallo <tzagallo>
Component: JavaScriptCoreAssignee: Tadeu Zagallo <tzagallo>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

Tadeu Zagallo
Reported 2020-07-28 15:36:46 PDT
<rdar://problem/65189677>
Attachments
Patch (3.95 KB, patch)
2020-07-28 16:13 PDT, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
Patch (3.99 KB, patch)
2020-07-29 07:54 PDT, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
Patch (3.99 KB, patch)
2020-07-29 13:12 PDT, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.95 KB, patch)
2020-07-29 15:34 PDT, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.94 KB, patch)
2020-07-29 15:36 PDT, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Tadeu Zagallo
Comment 1 2020-07-28 16:13:01 PDT
Created attachment 405426 [details] Patch
EWS
Comment 2 2020-07-28 18:20:55 PDT
Found 1 new test failure: workers/wasm-hashset.html
Tadeu Zagallo
Comment 3 2020-07-29 07:54:05 PDT
Created attachment 405458 [details] Patch
Saam Barati
Comment 4 2020-07-29 11:18:35 PDT
Comment on attachment 405458 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405458&action=review > Source/JavaScriptCore/wasm/WasmFunctionParser.h:639 > + if (i > firstArgumentIndex) why is this the fix?
Tadeu Zagallo
Comment 5 2020-07-29 13:12:48 PDT
Created attachment 405490 [details] Patch
Tadeu Zagallo
Comment 6 2020-07-29 15:34:27 PDT
Created attachment 405515 [details] Patch for landing
EWS
Comment 7 2020-07-29 15:35:20 PDT
ChangeLog entry in Source/JavaScriptCore/ChangeLog contains OOPS!.
Tadeu Zagallo
Comment 8 2020-07-29 15:36:15 PDT
Created attachment 405516 [details] Patch for landing
EWS
Comment 9 2020-07-29 16:15:13 PDT
Committed r265065: <https://trac.webkit.org/changeset/265065> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405516 [details].
Note You need to log in before you can comment on or make changes to this bug.