Bug 21490

Summary: Optimize keyframe style sheet changes by avoiding styleSheetChanged()
Product: WebKit Reporter: Chris Marrin <cmarrin>
Component: CSSAssignee: Chris Marrin <cmarrin>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dino, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Patch, including LayoutTest file darin: review+

Chris Marrin
Reported 2008-10-08 17:16:23 PDT
Back before I changed the way keyframe style was resolved (https://bugs.webkit.org/show_bug.cgi?id=20995), I needed to call styleSheetChanged() after deleting or inserting keyframe rules so the keyframe style could be recomputed. But this caused ALL style to be recomputed, which was really expensive and also required a complete redraw of the page. After the change it is no longer necessary to do the styleSheetChanged() call because RenderStyles are created as needed when the animation is started. removing this call will significantly improve performance of adding or removing keyframes.
Attachments
Patch, including LayoutTest file (6.55 KB, patch)
2008-10-08 17:19 PDT, Chris Marrin 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Marrin
Comment 1 2008-10-08 17:19:00 PDT
Created attachment 24209 [details] Patch, including LayoutTest file
Darin Adler
Comment 2 2008-10-11 13:22:27 PDT
Comment on attachment 24209 [details] Patch, including LayoutTest file r=me
Adam Barth
Comment 3 2008-10-14 01:42:24 PDT
Will land.
Adam Barth
Comment 4 2008-10-14 03:01:31 PDT
My Mac Mini died in the middle of testing this patch. I'm going to take it into the store tomorrow.
Simon Fraser (smfr)
Comment 5 2008-10-14 11:21:57 PDT
We'll land this
Chris Marrin
Comment 6 2008-10-14 14:31:55 PDT
Sending LayoutTests/ChangeLog Adding LayoutTests/css3/change-keyframes-expected.txt Adding LayoutTests/css3/change-keyframes.html Sending WebCore/ChangeLog Sending WebCore/css/WebKitCSSKeyframesRule.cpp Transmitting file data ..... Committed revision 37592.
Note You need to log in before you can comment on or make changes to this bug.