Bug 214893

Summary: [ Mac ] webgl/2.0.0/ tests failing after r264997
Product: WebKit Reporter: Truitt Savell <tsavell>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, jdarpinian, kbr, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 214792    
Bug Blocks: 126404    
Attachments:
Description Flags
Patch none

Truitt Savell
Reported 2020-07-28 13:23:16 PDT
Looks like after the update to webgl/2.0.0/ in https://trac.webkit.org/changeset/264997/webkit We are seeing these new failures webgl/2.0.0/conformance2/rendering/clear-srgb-color-buffer.html webgl/2.0.0/conformance/uniforms/gl-uniform-arrays.html history: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=webgl%2F2.0.0%2Fconformance2%2Frendering%2Fclear-srgb-color-buffer.html&test=webgl%2F2.0.0%2Fconformance%2Funiforms%2Fgl-uniform-arrays.html I will add more that I find to this bug
Attachments
Patch (2.60 KB, patch)
2020-07-28 13:45 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2020-07-28 13:28:01 PDT
webgl/2.0.0/conformance2/rendering/clear-srgb-color-buffer.html needs an increase to the tolerance. webgl/2.0.0/conformance/uniforms/gl-uniform-arrays.html looks like a flaky timeout in Debug - needs to be marked Slow in Debug.
Kenneth Russell
Comment 3 2020-07-28 13:45:15 PDT
Created attachment 405404 [details] Patch
Kenneth Russell
Comment 4 2020-07-28 13:46:15 PDT
The patch just uploaded should actually be the complete fix for this bug, so we can let the bug be closed by it. Let's please file any other regressions under a new bug - thanks.
EWS
Comment 5 2020-07-28 14:20:22 PDT
Committed r265007: <https://trac.webkit.org/changeset/265007> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405404 [details].
Radar WebKit Bug Importer
Comment 6 2020-07-28 14:21:24 PDT
<rdar://problem/66237181>
Note You need to log in before you can comment on or make changes to this bug.