Bug 214884

Summary: Allow multiple calls to PerformanceObserver.observe with different types
Product: WebKit Reporter: Rob Buis <rbuis>
Component: DOMAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Rob Buis
Reported 2020-07-28 10:17:01 PDT
Not having implemented this, tests like this one fail: performance-timeline/po-observe-type.any.html
Attachments
Patch (8.15 KB, patch)
2020-08-04 02:41 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (8.47 KB, patch)
2020-08-04 08:49 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (8.51 KB, patch)
2020-08-05 00:43 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2020-08-04 02:41:55 PDT
Created attachment 405911 [details] Patch
Rob Buis
Comment 2 2020-08-04 08:49:24 PDT
Created attachment 405923 [details] Patch
Radar WebKit Bug Importer
Comment 3 2020-08-04 10:17:17 PDT
<rdar://problem/66529156>
Darin Adler
Comment 4 2020-08-04 10:54:00 PDT
Comment on attachment 405923 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405923&action=review > Source/WebCore/page/PerformanceObserver.h:76 > + bool m_typeObserver { false }; This doesn’t seem to be a great name for a boolean. It sounds like the contents would be a "type observer", which sounds like an object, not a boolean. Maybe m_isTypeObserver?
Rob Buis
Comment 5 2020-08-05 00:43:48 PDT
Created attachment 405990 [details] Patch
EWS
Comment 6 2020-08-05 01:22:07 PDT
Committed r265281: <https://trac.webkit.org/changeset/265281> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405990 [details].
Note You need to log in before you can comment on or make changes to this bug.