Bug 214884

Summary: Allow multiple calls to PerformanceObserver.observe with different types
Product: WebKit Reporter: Rob Buis <rbuis>
Component: DOMAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Rob Buis 2020-07-28 10:17:01 PDT 
Not having implemented this, tests like this one fail:
performance-timeline/po-observe-type.any.html
Comment 1 Rob Buis 2020-08-04 02:41:55 PDT 
Created attachment 405911 [details]
Patch
Comment 2 Rob Buis 2020-08-04 08:49:24 PDT 
Created attachment 405923 [details]
Patch
Comment 3 Radar WebKit Bug Importer 2020-08-04 10:17:17 PDT 
<rdar://problem/66529156>
Comment 4 Darin Adler 2020-08-04 10:54:00 PDT 
Comment on attachment 405923 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405923&action=review

> Source/WebCore/page/PerformanceObserver.h:76
> +    bool m_typeObserver { false };

This doesn’t seem to be a great name for a boolean. It sounds like the contents would be a "type observer", which sounds like an object, not a boolean. Maybe m_isTypeObserver?
Comment 5 Rob Buis 2020-08-05 00:43:48 PDT 
Created attachment 405990 [details]
Patch
Comment 6 EWS 2020-08-05 01:22:07 PDT 
Committed r265281: <https://trac.webkit.org/changeset/265281>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405990 [details].