Bug 214864

Summary: Add missing Logging support for touch events
Product: WebKit Reporter: Marco Felsch <m.felsch>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: ahmad.saleem792, clopez, darin, m.felsch, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Marco Felsch
Reported 2020-07-28 01:20:50 PDT
Add missing Logging support for touch events
Attachments
Patch (2.13 KB, patch)
2020-07-28 01:31 PDT, Marco Felsch 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Marco Felsch
Comment 1 2020-07-28 01:31:11 PDT
Created attachment 405345 [details] Patch
Radar WebKit Bug Importer
Comment 2 2020-08-04 01:21:19 PDT
<rdar://problem/66512789>
Simon Fraser (smfr)
Comment 3 2020-08-05 13:02:17 PDT
Adding a new channel for just one log point seems a bit excessive. Should this be a “UserEvents” log channel, for future logging of other kinds of events? Also LOG_WITH_STREAM will give you more easily readable code.
Marco Felsch
Comment 4 2020-08-18 00:40:10 PDT
(In reply to Simon Fraser (smfr) from comment #3) > Adding a new channel for just one log point seems a bit excessive. Should > this be a “UserEvents” log channel, for future logging of other kinds of > events? Hm.. I just followed the MouseEvents implementation which also have only three callers. Should we consolidate this later on? > Also LOG_WITH_STREAM will give you more easily readable code. Didn't know LOG_WITH_STREAM() macro, thanks.
Carlos Alberto Lopez Perez
Comment 5 2021-11-25 09:29:57 PST
I see this patch already reviewed from time ago, and seems ready to land. Just a tip: next time you upload a patch pass this flag to the webkit-test-runner tool: "--request-commit" that way the reviewer knows he needs to set the cq+ flag for you. Otherwise he won't do that and the patch won't land. Do you want me to set cq+ (so the patch lands)? or are you planning to upload a new version of the patch?
Ahmad Saleem
Comment 6 2022-10-26 03:53:52 PDT
CheckingChecking via BugID, it seems this r+ patch didn't landed. Do we need this anymore? Thanks!
Note You need to log in before you can comment on or make changes to this bug.