Bug 21484

Summary: GDI text does not respect non-rectangular clipping
Product: WebKit Reporter: mitz
Component: TextAssignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: aroben
Priority: P2 Keywords: HasReduction, InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
Test case none

mitz
Reported 2008-10-08 13:40:44 PDT
The GDI text code path, when it does not take the drawIntoBitmap path, does not respect clipping paths on the GraphicsContext (and underlying CGContext) other than clipping rectangles. The reason is twofold: 1) In the CG/Win port, clipping a GraphicsContext to a path is not reflected on the DC side of the GraphicsContext 2) Even if it were, some code bypasses GraphicsContext and applies clipping to the CGContext directly, such as SVGResourceClipperCg.cpp (I know this is being worked on). I think clipping to a bitmap mask suffers from the same issue. To reproduce: 1) Open the attached test case in Safari on Windows 2) Quit Safari and set it up to use GDI (see <http://webkit.org/blog/168/gdi-text-on-windows/>) 3) Open the test case again, this time in GDI mode. Note how the text is not clipped to the circles.
Attachments
Test case (855 bytes, image/svg+xml)
2008-10-08 13:41 PDT, mitz 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2008-10-08 13:41:24 PDT
Created attachment 24197 [details] Test case
mitz
Comment 2 2008-10-08 13:41:50 PDT
<rdar://problem/6278984>
mitz
Comment 3 2009-01-08 19:50:36 PST
<http://trac.webkit.org/projects/webkit/changeset/39736> includes WebKit changes to support fixing this bug.
mitz
Comment 4 2011-11-03 09:45:20 PDT
This was fixed in <http://trac.webkit.org/changeset/39736> if I remember correctly.
Note You need to log in before you can comment on or make changes to this bug.