Bug 214783

Summary: scaleResolutionDownBy has no effect on RTCRtpSender
Product: WebKit Reporter: Ben <ben.browitt>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, rackler, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Safari 13   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=214888
Attachments:
Description Flags
Patch
none
Increasing timer
none
Patch for landing none

Description Ben 2020-07-25 00:59:14 PDT
scaleResolutionDownBy has no effect parameter in RTCRtpSender.setParameters(). It works in Chrome and Firefox but has no effect in Safari.

Tested with [1] taken from [2].
Safari 13.1.2 on macOS
Safari on iPadOS 13.6

[1] https://jsfiddle.net/jib1/kv14z7r6/
[2] https://stackoverflow.com/a/29359319
Comment 1 Radar WebKit Bug Importer 2020-07-25 13:19:35 PDT
<rdar://problem/66108346>
Comment 2 youenn fablet 2020-07-27 09:24:44 PDT
Created attachment 405284 [details]
Patch
Comment 3 EWS 2020-07-27 10:31:03 PDT
Committed r264930: <https://trac.webkit.org/changeset/264930>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405284 [details].
Comment 4 Karl Rackler 2020-07-28 18:59:03 PDT
Reverted r264930 for reason:

Reverting Pre-Submission Testing

Committed r265026: <https://trac.webkit.org/changeset/265026>
Comment 5 Ryan Haddad 2020-07-28 22:38:13 PDT
Reopening due to revert.

The test modified with this change became a flaky failure on iOS debug bots.
See https://bugs.webkit.org/show_bug.cgi?id=214888
Comment 6 youenn fablet 2020-07-29 05:54:45 PDT
Created attachment 405451 [details]
Increasing timer
Comment 7 EWS 2020-07-29 10:14:12 PDT
ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.
Comment 8 youenn fablet 2020-07-29 10:16:11 PDT
Created attachment 405470 [details]
Patch for landing
Comment 9 EWS 2020-07-29 11:11:19 PDT
Committed r265047: <https://trac.webkit.org/changeset/265047>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405470 [details].