Summary: | [Win10] js/weakref-finalizationregistry.html is frequently timing out | ||
---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> |
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW --- | ||
Severity: | Normal | CC: | Hironori.Fujii, keith_miller, webkit-bot-watchers-bugzilla, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | Other | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Description
Ryan Haddad
2020-07-22 21:12:41 PDT
Man, gc tests are a real nightmare... WinCairo Debug and Release tester are constantly timing out. GTK Debug is ramdomly timing out. https://results.webkit.org/?suite=layout-tests&test=js%2Fweakref-finalizationregistry.html It's flaky timeout for WinCairo Debug on my PC. But, it will pass constantly by applying this patch. diff --git a/LayoutTests/js/script-tests/weakref-finalizationregistry.js b/LayoutTests/js/script-tests/weakref-finalizationregistry.js index 130c6c81d4de..be85642f01f0 100644 --- a/LayoutTests/js/script-tests/weakref-finalizationregistry.js +++ b/LayoutTests/js/script-tests/weakref-finalizationregistry.js @@ -18,7 +18,7 @@ function turnEventLoop() { setTimeout(() => { gc(); resolve(); - }, 1); + }, 30); }); } Does GC thread need a time to collect? The commit message of 248952@main explains why it wait for 1ms. > * js/script-tests/weakref-finalizationregistry.js: > (turnEventLoop): Use a timeout of 1ms instead of 0ms so that > the deferred work task that calls the JS FinalizationRegistry > callback gets a chance to run before we continue on to the > assertion that it was run. |