| Summary: | Monitor the case of a fetch event not able to register to the respondWith promise | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
| Component: | Service Workers | Assignee: | youenn fablet <youennf> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | achristensen, cdumez, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Local Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
youenn fablet
2020-07-22 02:12:49 PDT
Created attachment 404909 [details]
Patch
Created attachment 404914 [details]
Patch
Ping review Comment on attachment 404914 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404914&action=review > Source/WebCore/bindings/js/JSDOMPromise.h:53 > + static bool whenPromiseIsSettled(JSDOMGlobalObject*, JSC::JSObject* promise, Function<void()>&&); I think this needs a 2-state enum. "true" and "false" don't really make sense here. > Source/WebCore/workers/service/FetchEvent.cpp:78 > + bool isRegistered = m_respondPromise->whenSettled([this, protectedThis = makeRef(*this)] () { () is unnecessary. Created attachment 405141 [details]
Patch for landing
Committed r264838: <https://trac.webkit.org/changeset/264838> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405141 [details]. |