Bug 214631

Summary: Monitor the case of a fetch event not able to register to the respondWith promise
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

youenn fablet
Reported 2020-07-22 02:12:49 PDT
Monitor the case of a fetch event not able to register to the respondWith promise
Attachments
Patch (5.03 KB, patch)
2020-07-22 02:18 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (5.03 KB, patch)
2020-07-22 04:33 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.24 KB, patch)
2020-07-24 07:17 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-07-22 02:18:34 PDT
Created attachment 404909 [details] Patch
youenn fablet
Comment 2 2020-07-22 04:33:53 PDT
Created attachment 404914 [details] Patch
youenn fablet
Comment 3 2020-07-23 05:54:02 PDT
Ping review
Alex Christensen
Comment 4 2020-07-23 10:37:18 PDT
Comment on attachment 404914 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404914&action=review > Source/WebCore/bindings/js/JSDOMPromise.h:53 > + static bool whenPromiseIsSettled(JSDOMGlobalObject*, JSC::JSObject* promise, Function<void()>&&); I think this needs a 2-state enum. "true" and "false" don't really make sense here. > Source/WebCore/workers/service/FetchEvent.cpp:78 > + bool isRegistered = m_respondPromise->whenSettled([this, protectedThis = makeRef(*this)] () { () is unnecessary.
youenn fablet
Comment 5 2020-07-24 07:17:01 PDT
Created attachment 405141 [details] Patch for landing
EWS
Comment 6 2020-07-24 10:18:26 PDT
Committed r264838: <https://trac.webkit.org/changeset/264838> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405141 [details].
Radar WebKit Bug Importer
Comment 7 2020-07-24 10:19:16 PDT
<rdar://problem/66060529>
Note You need to log in before you can comment on or make changes to this bug.