Summary: | We should have exception check after promise operation | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||
Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | mark.lam, webkit-bug-importer, youennf | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Yusuke Suzuki
2020-07-21 12:20:52 PDT
Created attachment 404849 [details]
Patch
Comment on attachment 404849 [details]
Patch
r=me
Created attachment 405029 [details]
Patch
Comment on attachment 405029 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405029&action=review > Source/WebCore/bindings/js/JSDOMPromiseDeferred.cpp:187 > + EXCEPTION_ASSERT(!scope.exception() || isTerminatedExecutionException(lexicalGlobalObject.vm(), scope.exception())); Should we add this line in other places like reject(Exception...)? Comment on attachment 405029 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405029&action=review >> Source/WebCore/bindings/js/JSDOMPromiseDeferred.cpp:187 >> + EXCEPTION_ASSERT(!scope.exception() || isTerminatedExecutionException(lexicalGlobalObject.vm(), scope.exception())); > > Should we add this line in other places like reject(Exception...)? Let's only do this as needed for now. I think we need a better mental model for TerminatedExecutionExceptions, OOMEs, and StackOverflowErrors better for CatchScope. We may want to replace these eventually. No need to do additional work until we have the better model. > LayoutTests/js/dom/promise-should-have-exception-check-on-operation.html:9 > +SubtleCrypto.prototype.deriveBits(); From the win EWS, it looks like SubtleCrypto isn't available on OS(Windows). Can you confirm if this is the case, and if so, add a TestExpectation for Windows port to expect this test to fail? r=me too. Comment on attachment 405029 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405029&action=review >> LayoutTests/js/dom/promise-should-have-exception-check-on-operation.html:9 >> +SubtleCrypto.prototype.deriveBits(); > > From the win EWS, it looks like SubtleCrypto isn't available on OS(Windows). Can you confirm if this is the case, and if so, add a TestExpectation for Windows port to expect this test to fail? Nice catch. I'll fix it. Created attachment 405072 [details]
Patch for landing
webaudio/webaudio-gc.html crashes but it was before this patch. Committed r264802: <https://trac.webkit.org/changeset/264802> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405072 [details]. |