Bug 214603

Summary: llint_slow_path_get_private_name() should not be using PropertySlot::InternalMethodType::VMInquiry.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
none
proposed patch. ysuzuki: review+

Mark Lam
Reported 2020-07-21 11:06:39 PDT
VMInquiry means (1) the get operation should not call back into JS, (2) it should not throw any exceptions (except for OutOfMemoryError or StackOverflowError which can be thrown at any time), or have any side effects that is observable from JS code. In this case, llint_slow_path_get_private_name() is just implementating PrivateFieldGet (https://tc39.es/proposal-class-fields/#sec-privatefieldget) and has no need to use VMInquiry.
Attachments
proposed patch. (3.17 KB, patch)
2020-07-21 11:12 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
proposed patch. (4.16 KB, patch)
2020-07-21 11:35 PDT, Mark Lam 		ysuzuki: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2020-07-21 11:12:10 PDT
Created attachment 404839 [details] proposed patch.
Mark Lam
Comment 2 2020-07-21 11:35:52 PDT
Created attachment 404841 [details] proposed patch.
Yusuke Suzuki
Comment 3 2020-07-21 12:27:07 PDT
Comment on attachment 404841 [details] proposed patch. r=me
Mark Lam
Comment 4 2020-07-21 14:11:24 PDT
Thanks for the review. Landed in r264679: <http://trac.webkit.org/r264679>.
Radar WebKit Bug Importer
Comment 5 2020-07-21 14:12:15 PDT
<rdar://problem/65902335>
Note You need to log in before you can comment on or make changes to this bug.