Bug 214603

Summary: llint_slow_path_get_private_name() should not be using PropertySlot::InternalMethodType::VMInquiry.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
none
proposed patch. ysuzuki: review+

Description Mark Lam 2020-07-21 11:06:39 PDT 
VMInquiry means (1) the get operation should not call back into JS, (2) it should not throw any exceptions (except for OutOfMemoryError or StackOverflowError which can be thrown at any time), or have any side effects that is observable from JS code.  In this case, llint_slow_path_get_private_name() is just implementating PrivateFieldGet (https://tc39.es/proposal-class-fields/#sec-privatefieldget) and has no need to use VMInquiry.
Comment 1 Mark Lam 2020-07-21 11:12:10 PDT 
Created attachment 404839 [details]
proposed patch.
Comment 2 Mark Lam 2020-07-21 11:35:52 PDT 
Created attachment 404841 [details]
proposed patch.
Comment 3 Yusuke Suzuki 2020-07-21 12:27:07 PDT 
Comment on attachment 404841 [details]
proposed patch.

r=me
Comment 4 Mark Lam 2020-07-21 14:11:24 PDT 
Thanks for the review.  Landed in r264679: <http://trac.webkit.org/r264679>.
Comment 5 Radar WebKit Bug Importer 2020-07-21 14:12:15 PDT 
<rdar://problem/65902335>