Bug 214599

Summary: WebKit::UserData::decode() and encode() do not need a default: case
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebKit2Assignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED INVALID    
Severity: Normal CC: useafterfree, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=214587
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2020-07-21 09:58:10 PDT
WebKit::UserData::decode() and encode() do not need a default: case. This prevents compiler warnings if a new enum is ever added to EncodedDataType. <rdar://problem/65777928>
Attachments
Patch v1 (12.88 KB, patch)
2020-07-21 10:02 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2020-07-21 10:02:29 PDT
Created attachment 404829 [details] Patch v1
David Kilzer (:ddkilzer)
Comment 2 2020-07-21 12:46:37 PDT
Heh...didn't realize how many "missing" values there were: In file included from /Volumes/Data/worker/iOS-13-Build-EWS/build/WebKitBuild/Release-iphoneos/DerivedSources/WebKit2/unified-sources/UnifiedSource23.cpp:4: /Volumes/Data/worker/iOS-13-Build-EWS/build/Source/WebKit/Shared/UserData.cpp:171:20: error: 111 enumeration values not handled in switch: 'Null', 'AuthenticationChallenge', 'AuthenticationDecisionListener'... [-Werror,-Wswitch] switch (object.type()) { ^ /Volumes/Data/worker/iOS-13-Build-EWS/build/Source/WebKit/Shared/UserData.cpp:171:20: note: add missing switch cases switch (object.type()) { ^ /Volumes/Data/worker/iOS-13-Build-EWS/build/Source/WebKit/Shared/UserData.cpp:342:13: error: 110 enumeration values not handled in switch: 'AuthenticationChallenge', 'AuthenticationDecisionListener', 'Connection'... [-Werror,-Wswitch] Don't need to fix this.
Note You need to log in before you can comment on or make changes to this bug.