Summary: | Debug build is failing after r264537 on Linux | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Caio Lima <ticaiolima> | ||||||
Component: | JavaScriptCore | Assignee: | Caio Lima <ticaiolima> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | darin, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Caio Lima
2020-07-21 09:10:01 PDT
Created attachment 404824 [details]
Patch
Comment on attachment 404824 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404824&action=review > Source/JavaScriptCore/runtime/IntlObject.cpp:-657 > - ASSERT_UNDER_CONSTEXPR_CONTEXT(0); Does ASSERT_UNDER_CONSTEXPR_CONTEXT work at all on this "Linux context"? (In reply to Darin Adler from comment #2) > Comment on attachment 404824 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=404824&action=review > > > Source/JavaScriptCore/runtime/IntlObject.cpp:-657 > > - ASSERT_UNDER_CONSTEXPR_CONTEXT(0); > > Does ASSERT_UNDER_CONSTEXPR_CONTEXT work at all on this "Linux context"? It seems that whenever the `assert` is falsy, it triggers compilation error due to call of `WTFReportAssertionFailure`. I spent sometime trying to understand why, but got no success yet. Comment on attachment 404824 [details]
Patch
Yusuke suggested removing the ASSERT_UNDER_CONSTEXPR_CONTEXT entirely and not changing this from constexpr to inline.
Comment on attachment 404824 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404824&action=review >>> Source/JavaScriptCore/runtime/IntlObject.cpp:-657 >>> - ASSERT_UNDER_CONSTEXPR_CONTEXT(0); >> >> Does ASSERT_UNDER_CONSTEXPR_CONTEXT work at all on this "Linux context"? > > It seems that whenever the `assert` is falsy, it triggers compilation error due to call of `WTFReportAssertionFailure`. I spent sometime trying to understand why, but got no success yet. I think removing this assertion is better for now. GCC seems not handling switch's reachability correctly. Created attachment 404842 [details]
Patch
Committed r264671: <https://trac.webkit.org/changeset/264671> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404842 [details]. |