Bug 214540

Summary: Use forward template declarations for ColorComponents instead of including ColorComponents.h
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: PlatformAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, don.olmstead, ross.kirsling, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Fujii Hironori 2020-07-19 19:23:35 PDT 
Use forward template declarations for ColorComponents instead of including ColorComponents.h

r264289 isn't a right fix.

(In reply to Darin Adler from bug #214204 comment #20)
> I’m not sure moving the include to the header was the best fix. We might
> have been able to just forward declare in the header and include only in the
> files that were using that template.
Comment 1 Fujii Hironori 2020-07-19 19:29:57 PDT 
Created attachment 404692 [details]
Patch
Comment 2 Darin Adler 2020-07-19 19:34:10 PDT 
Comment on attachment 404692 [details]
Patch

Let's wait for EWS results.
Comment 3 Fujii Hironori 2020-07-19 23:11:44 PDT 
Yup. All EWS are green. And, I confirmed WinCairo non-unified builds using Clang is fine.
Comment 4 Fujii Hironori 2020-07-20 01:37:30 PDT 
Comment on attachment 404692 [details]
Patch

Clearing flags on attachment: 404692

Committed r264593: <https://trac.webkit.org/changeset/264593>
Comment 5 Fujii Hironori 2020-07-20 01:37:33 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-07-20 01:38:17 PDT 
<rdar://problem/65813423>