Bug 214540

Summary: Use forward template declarations for ColorComponents instead of including ColorComponents.h
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: PlatformAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, don.olmstead, ross.kirsling, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Fujii Hironori
Reported 2020-07-19 19:23:35 PDT
Use forward template declarations for ColorComponents instead of including ColorComponents.h r264289 isn't a right fix. (In reply to Darin Adler from bug #214204 comment #20) > I’m not sure moving the include to the header was the best fix. We might > have been able to just forward declare in the header and include only in the > files that were using that template.
Attachments
Patch (1.79 KB, patch)
2020-07-19 19:29 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2020-07-19 19:29:57 PDT
Created attachment 404692 [details] Patch
Darin Adler
Comment 2 2020-07-19 19:34:10 PDT
Comment on attachment 404692 [details] Patch Let's wait for EWS results.
Fujii Hironori
Comment 3 2020-07-19 23:11:44 PDT
Yup. All EWS are green. And, I confirmed WinCairo non-unified builds using Clang is fine.
Fujii Hironori
Comment 4 2020-07-20 01:37:30 PDT
Comment on attachment 404692 [details] Patch Clearing flags on attachment: 404692 Committed r264593: <https://trac.webkit.org/changeset/264593>
Fujii Hironori
Comment 5 2020-07-20 01:37:33 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2020-07-20 01:38:17 PDT
<rdar://problem/65813423>
Note You need to log in before you can comment on or make changes to this bug.