Bug 214410

Summary: Integrate libwebm into the libwebrtc project.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, annulen, eric.carlson, ews-watchlist, glenn, gyuyoung.kim, jbedard, peng.liu6, philipj, ryuan.choi, sergio, webkit-bug-importer, youennf, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=214450
https://bugs.webkit.org/show_bug.cgi?id=214478
Bug Depends on: 214477    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Jer Noble
Reported 2020-07-16 09:29:44 PDT
Integrate libwebm into the libwebrtc project.
Attachments
Patch (2.88 MB, patch)
2020-07-16 10:02 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (2.93 MB, patch)
2020-07-16 11:00 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (2.89 MB, patch)
2020-07-16 13:28 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-07-16 10:02:39 PDT
<rdar://problem/65672748>
Jer Noble
Comment 2 2020-07-16 10:02:42 PDT
Created attachment 404458 [details] Patch
Jer Noble
Comment 3 2020-07-16 11:00:13 PDT
Created attachment 404465 [details] Patch
Jer Noble
Comment 4 2020-07-16 13:28:27 PDT
Created attachment 404479 [details] Patch
Eric Carlson
Comment 5 2020-07-16 15:39:36 PDT
Comment on attachment 404479 [details] Patch rs=me once the bots are happy
EWS
Comment 6 2020-07-16 18:10:20 PDT
Committed r264492: <https://trac.webkit.org/changeset/264492> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404479 [details].
Yusuke Suzuki
Comment 7 2020-07-17 08:28:44 PDT
Re-opened since this is blocked by bug 214477
Jonathan Bedard
Comment 8 2020-07-17 08:30:26 PDT
Broke the iOS 13 Debug build: https://build.webkit.org/builders/Apple%20iOS%2013%20Simulator%20Debug%20(Build)?numbuilds=50 Note that r264491 changed a script only used to configure bots, so r264492 can be confidently blamed for the build failure.
Jer Noble
Comment 9 2020-07-20 09:34:47 PDT
(In reply to Jonathan Bedard from comment #8) > Broke the iOS 13 Debug build: > https://build.webkit.org/builders/ > Apple%20iOS%2013%20Simulator%20Debug%20(Build)?numbuilds=50 > > Note that r264491 changed a script only used to configure bots, so r264492 > can be confidently blamed for the build failure. This build failure was fixed by r264517 <https://trac.webkit.org/changeset/264517/webkit> without a roll-out needed. Re-closing.
Note You need to log in before you can comment on or make changes to this bug.