Bug 214396

Summary: [Big Sur] Build on Seed 1
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, benjamin, cdumez, cmarcelo, ews-watchlist, rbuis, saagar, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=214043
https://bugs.webkit.org/show_bug.cgi?id=214235
https://bugs.webkit.org/show_bug.cgi?id=214253
https://bugs.webkit.org/show_bug.cgi?id=214415
Attachments:
Description Flags
Patch none

Jonathan Bedard
Reported 2020-07-15 21:41:19 PDT
WebKit should build with Seed 1's SDK for MacOS.
Attachments
Patch (4.06 KB, patch)
2020-07-15 22:25 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-07-15 21:41:35 PDT
<rdar://problem/65644762>
Jonathan Bedard
Comment 2 2020-07-15 22:25:40 PDT
Created attachment 404423 [details] Patch
Rob Buis
Comment 3 2020-07-16 00:23:39 PDT
*** Bug 214235 has been marked as a duplicate of this bug. ***
Rob Buis
Comment 4 2020-07-16 00:26:11 PDT
*** Bug 214253 has been marked as a duplicate of this bug. ***
EWS
Comment 5 2020-07-16 06:30:39 PDT
Committed r264453: <https://trac.webkit.org/changeset/264453> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404423 [details].
Jonathan Bedard
Comment 6 2020-07-16 09:29:27 PDT
Committed r264462: <https://trac.webkit.org/changeset/264462>
Saagar Jha
Comment 7 2020-07-16 09:45:21 PDT
I already got the HAVE_LARGE_CONTROL_SIZE and +[NSImage _imageWithSystemSymbolName:] merged in: https://bugs.webkit.org/show_bug.cgi?id=214338. There's two of those now :)
Jonathan Bedard
Comment 8 2020-07-16 09:57:41 PDT
(In reply to Saagar Jha from comment #7) > I already got the HAVE_LARGE_CONTROL_SIZE and +[NSImage > _imageWithSystemSymbolName:] merged in: > https://bugs.webkit.org/show_bug.cgi?id=214338. There's two of those now :) Which there shouldn't be, I'll de-duplicate shortly.
Note You need to log in before you can comment on or make changes to this bug.