Bug 214390

Summary: MiniBrowser toolbar is ugly with default macOS Big Sur style
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: sam, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
thorton: review+
Before
none
After (in dark mode) none

Dean Jackson
Reported 2020-07-15 17:59:08 PDT
MiniBrowser toolbar is ugly with default macOS Big Sur styl
Attachments
Patch (13.05 KB, patch)
2020-07-15 18:03 PDT, Dean Jackson 		thorton: review+
DetailsFormatted DiffDiff
Before (70.38 KB, image/png)
2020-07-15 18:06 PDT, Dean Jackson 		no flags
Details
After (in dark mode) (45.06 KB, image/png)
2020-07-15 18:07 PDT, Dean Jackson 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-07-15 17:59:40 PDT
<rdar://problem/65637420>
Dean Jackson
Comment 2 2020-07-15 18:03:12 PDT
Created attachment 404409 [details] Patch
Dean Jackson
Comment 3 2020-07-15 18:06:25 PDT
Created attachment 404410 [details] Before
Dean Jackson
Comment 4 2020-07-15 18:07:34 PDT
Created attachment 404411 [details] After (in dark mode)
Tim Horton
Comment 5 2020-07-15 18:15:13 PDT
Comment on attachment 404409 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404409&action=review > Tools/MiniBrowser/mac/BrowserWindowController.m:46 > +#if TARGET_OS_OSX && __MAC_OS_X_VERSION_MIN_REQUIRED >= 110000 Why the TARGET_ check? > Tools/MiniBrowser/mac/BrowserWindowController.m:51 > + reloadButton.image = [NSImage imageWithSystemSymbolName:@"arrow.clockwise" accessibilityDescription:@"Reload"]; I believe it is possible to specify symbols in IB? But I could be wrong.
Sam Weinig
Comment 6 2020-07-15 18:31:35 PDT
Seems like @available should be used instead for best practices here.
Dean Jackson
Comment 7 2020-07-15 18:39:47 PDT
Committed r264441: <https://trac.webkit.org/changeset/264441>
Note You need to log in before you can comment on or make changes to this bug.