Bug 214381 – Added Fixes for AudioScheduledSourceNode

• Component: Web Audio
• Status: RESOLVED FIXED

[Clark Wang]

Added in IDL file for AudioScheduledSourceNode and other fixes for this interface. Added in ConstantSourceOptions files. Removed unrestricted keyword from attributes in BaseAudioContext.idl to match spec.

[Clark Wang]

Created attachment 404401 [details]
Patch

[Clark Wang]

Created attachment 404438 [details]
Patch

[Chris Dumez]

Comment on attachment 404438 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404438&action=review

> Source/WebCore/ChangeLog:9
> +        Added in ConstantSourceOptions files. Removed unrestricted keyword from attributes in 

Please do not put unrelated changes in a single patch.

[Clark Wang]

Ok, let me split up these changes into separate patches. Thanks!

[Clark Wang]

Created attachment 404450 [details]
Patch

[Chris Dumez]

Comment on attachment 404450 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404450&action=review

> Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl:29
>      ActiveDOMObject,

You should be able to drop this now.

> Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl:30
> +] interface AudioBufferSourceNode : AudioScheduledSourceNode {

Well, then you'd want to drop start() / stop() / onended from this interface..

> Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp:139
> +ExceptionOr<void> AudioScheduledSourceNode::startLater(Optional<double> optionalWhen)

That's wrong. There is already a default value of 0 in the IDL so the generated bindings will always give you a double.

> Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp:159
> +ExceptionOr<void> AudioScheduledSourceNode::stopLater(Optional<double> optionalWhen)

Ditto.

> Source/WebCore/Modules/webaudio/OscillatorNode.idl:37
>      ActiveDOMObject,

You should be able to drop this now.

> Source/WebCore/Modules/webaudio/OscillatorNode.idl:38
> +] interface OscillatorNode : AudioScheduledSourceNode {

Well, then you'd want to drop start() / stop() / onended from this interface..

[Chris Dumez]

Comment on attachment 404450 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404450&action=review

> Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl:29
>      ActiveDOMObject,

You should be able to drop this now.

> Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl:30
> +] interface AudioBufferSourceNode : AudioScheduledSourceNode {

Well, then you'd want to drop start() / stop() / onended from this interface..

> Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp:139
> +ExceptionOr<void> AudioScheduledSourceNode::startLater(Optional<double> optionalWhen)

That's wrong. There is already a default value of 0 in the IDL so the generated bindings will always give you a double.

> Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp:159
> +ExceptionOr<void> AudioScheduledSourceNode::stopLater(Optional<double> optionalWhen)

Ditto.

> Source/WebCore/Modules/webaudio/OscillatorNode.idl:37
>      ActiveDOMObject,

You should be able to drop this now.

> Source/WebCore/Modules/webaudio/OscillatorNode.idl:38
> +] interface OscillatorNode : AudioScheduledSourceNode {

Well, then you'd want to drop start() / stop() / onended from this interface..

[Clark Wang]

Created attachment 404486 [details]
Patch

[Clark Wang]

Created attachment 404576 [details]
Patch

[EWS]

Committed r264538: <https://trac.webkit.org/changeset/264538>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404576 [details].

[Radar WebKit Bug Importer]

<rdar://problem/65746671>