Summary: | [WinCairo] ANGLE D3D renderer can crash when PlatformDisplayWin is destructed in IPC thread | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||
Component: | Platform | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | don.olmstead, ross.kirsling, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Fujii Hironori
2020-07-12 14:20:08 PDT
ANGLE D3D renderer isn't thread-safe. PlatformDisplay was destructed in IPC thread. This is not expected for WinCairo. WinCairo shouldn't destruct PlatformDisplay because it can cause crash (Bug 170331). PlatformDisplay::sharedDisplay has static variable of std::unique_ptr<PlatformDisplay>. This triggers PlatformDisplay dtor. This is not expected for WinCairo. Created attachment 405333 [details]
Patch
Comment on attachment 405333 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405333&action=review r=me with nit about name > Source/WebCore/ChangeLog:3 > + [WinCairo] ANGLE D3D renderer rarely crashes while destructing PlatformDisplayWin in IPC thread Maybe a better bug name would be something like this? [WinCairo] ANGLE D3D renderer can crash when PlatformDisplayWin is destructed in IPC thread Committed r265003: <https://trac.webkit.org/changeset/265003> |