Bug 214239

Summary: Some further streamlining of Gradient handling code
Product: WebKit Reporter: Darin Adler <darin>
Component: Layout and RenderingAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bfulgham, cdumez, changseok, cmarcelo, dino, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, kondapallykalyan, pdr, sabouhallawa, sam, schenney, sergio, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Darin Adler
Reported 2020-07-12 13:33:00 PDT
Some further streamlining of Gradient handling code
Attachments
Patch (29.39 KB, patch)
2020-07-12 13:53 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (29.42 KB, patch)
2020-07-12 14:16 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2020-07-12 13:53:35 PDT Comment hidden (obsolete)
Darin Adler
Comment 2 2020-07-12 14:16:31 PDT
Created attachment 404116 [details] Patch
Darin Adler
Comment 3 2020-07-12 17:03:57 PDT
Parts of this were driven by Sam’s comments on my last patch.
Darin Adler
Comment 4 2020-07-12 18:36:41 PDT
Comment on attachment 404116 [details] Patch Passing all the EWS tests.
Sam Weinig
Comment 5 2020-07-12 19:12:05 PDT
Comment on attachment 404116 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404116&action=review > Source/WebCore/rendering/svg/RenderSVGResourceGradient.cpp:150 > + gradient->setGradientSpaceTransform(userspaceTransform); > + > + return { WTFMove(gradient), userspaceTransform }; What is the purpose of storing the userspaceTransform both on the Gradient and in the GradientData?
Darin Adler
Comment 6 2020-07-12 20:44:40 PDT
Comment on attachment 404116 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404116&action=review >> Source/WebCore/rendering/svg/RenderSVGResourceGradient.cpp:150 >> + return { WTFMove(gradient), userspaceTransform }; > > What is the purpose of storing the userspaceTransform both on the Gradient and in the GradientData? I asked myself the same question. > Source/WebCore/rendering/svg/RenderSVGResourceGradient.cpp:174 > + gradientData.gradient->setGradientSpaceTransform(transformOnNonScalingStroke(&renderer, gradientData.userspaceTransform)); Here is where it’s used. The only place it’s used. Maybe it could be removed. I don’t understand it well enough to be sure at this point.
EWS
Comment 7 2020-07-12 21:09:24 PDT
Committed r264290: <https://trac.webkit.org/changeset/264290> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404116 [details].
Radar WebKit Bug Importer
Comment 8 2020-07-12 21:10:12 PDT
<rdar://problem/65453742>
Note You need to log in before you can comment on or make changes to this bug.