Summary: | Add OK button to Date/Time form controls. | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Megan Gardner <megan_gardner> | ||||||||||||||||
Component: | New Bugs | Assignee: | Megan Gardner <megan_gardner> | ||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||
Severity: | Normal | CC: | aakash_jain, ap, darin, sam, thorton, webkit-bot-watchers-bugzilla, wenson_hsieh, ysuzuki | ||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=214517 | ||||||||||||||||||
Bug Depends on: | 214518 | ||||||||||||||||||
Bug Blocks: | |||||||||||||||||||
Attachments: |
|
Description
Megan Gardner
2020-07-10 12:36:04 PDT
Created attachment 404017 [details]
Patch
Created attachment 404020 [details]
Patch
Comment on attachment 404017 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404017&action=review > Source/WebKit/ChangeLog:10 > + Add 'OK' button to add clarity to UI, and increase the default size of the control to > + ensure space for both buttons. Also fixed a crash that happened when closing the control before > + the animation completed. Please add tests for all these things. Created attachment 404188 [details]
Patch
Comment on attachment 404188 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404188&action=review > Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:86 > + auto size = [view systemLayoutSizeFittingSize:UILayoutFittingCompressedSize]; Extra space after "=" here. > Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:88 > + if (size.width < 250) > + size.width = 250; std::max might be a nicer way to write this. Created attachment 404626 [details]
Patch for landing
Created attachment 404627 [details]
Patch for landing
Committed r264563: <https://trac.webkit.org/changeset/264563> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404627 [details]. > Committed r264563: <https://trac.webkit.org/changeset/264563> This broke the watchOS build. See Bug 214517. The latest patch wasn't run through the EWS. Please make sure to run the patches through EWS before landing. Commit-queue only builds and tests for macOS. Re-opened since this is blocked by bug 214518 Created attachment 404755 [details]
Patch
Created attachment 404772 [details]
Patch for landing
Committed r264637: <https://trac.webkit.org/changeset/264637> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404772 [details]. |