Summary: | [GStreamer] ImageDecoder hits more Debug ASSERTs | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||||
Component: | Platform | Assignee: | Philippe Normand <pnormand> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | calvaris, cgarcia, ews-watchlist, gustavo, menard, vjaquez, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Philippe Normand
2020-07-10 10:38:56 PDT
Created attachment 404667 [details]
Patch
Comment on attachment 404667 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404667&action=review > Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:260 > + GST_DEBUG("EOS on decoder %p", this); Nit, you can leave this out of the scope. > Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:372 > + while (!m_eos) { Shouldn't be this access protected by the m_sampleMutex? It looks it is set in other places protected. Created attachment 404701 [details]
Patch
Committed r264595: <https://trac.webkit.org/changeset/264595> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404701 [details]. |