Bug 214126

Summary:

Multiplex the HID and GameController gamepad providers on Mac

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebKit Misc.

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

thorton

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	thorton: review+
PFL	none

Brady Eidson

Reported 2020-07-08 23:38:46 PDT

Multiplex the HID and GameController gamepad providers on Mac Both providers have worked fine on Mac for awhile. By teaching WebKit how to use both at the same time, we get more gamepads, and better support for GameController.framework devices

Attachments
Patch (29.71 KB, patch) 2020-07-08 23:50 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (29.80 KB, patch) 2020-07-09 08:45 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (29.89 KB, patch) 2020-07-09 08:48 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (29.84 KB, patch) 2020-07-09 09:05 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (30.07 KB, patch) 2020-07-09 09:30 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (30.07 KB, patch) 2020-07-09 09:52 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (31.51 KB, patch) 2020-07-09 10:43 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (31.57 KB, patch) 2020-07-09 10:50 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (32.62 KB, patch) 2020-07-09 11:54 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (32.64 KB, patch) 2020-07-09 12:05 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (32.60 KB, patch) 2020-07-09 12:26 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (32.64 KB, patch) 2020-07-09 12:30 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (32.92 KB, patch) 2020-07-09 12:45 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (33.05 KB, patch) 2020-07-09 13:04 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (33.29 KB, patch) 2020-07-09 13:19 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (30.86 KB, patch) 2020-07-09 13:37 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (37.74 KB, patch) 2020-07-09 14:22 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (37.86 KB, patch) 2020-07-09 14:31 PDT, Brady Eidson	thorton: review+	Details Formatted Diff Diff
PFL (41.89 KB, patch) 2020-07-09 17:41 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Show Obsolete (17) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2020-07-08 23:41:14 PDT

<rdar://problem/63192532>

Brady Eidson

Comment 2 2020-07-08 23:50:34 PDT

Created attachment 403848 [details] Patch

Brady Eidson

Comment 3 2020-07-09 08:45:20 PDT

Created attachment 403870 [details] Patch

Brady Eidson

Comment 4 2020-07-09 08:48:10 PDT

Created attachment 403871 [details] Patch

Brady Eidson

Comment 5 2020-07-09 09:05:53 PDT

Created attachment 403872 [details] Patch

Brady Eidson

Comment 6 2020-07-09 09:30:44 PDT

Created attachment 403877 [details] Patch

Brady Eidson

Comment 7 2020-07-09 09:52:39 PDT

Created attachment 403878 [details] Patch

Brady Eidson

Comment 8 2020-07-09 10:43:49 PDT

Created attachment 403888 [details] Patch

Brady Eidson

Comment 9 2020-07-09 10:50:27 PDT

Created attachment 403889 [details] Patch

Brady Eidson

Comment 10 2020-07-09 11:54:43 PDT

Created attachment 403896 [details] Patch

Brady Eidson

Comment 11 2020-07-09 12:05:00 PDT

Created attachment 403901 [details] Patch

Brady Eidson

Comment 12 2020-07-09 12:26:14 PDT

Created attachment 403903 [details] Patch

Brady Eidson

Comment 13 2020-07-09 12:30:30 PDT

Created attachment 403904 [details] Patch

Brady Eidson

Comment 14 2020-07-09 12:45:29 PDT

Created attachment 403905 [details] Patch

Brady Eidson

Comment 15 2020-07-09 13:04:25 PDT

Created attachment 403907 [details] Patch

Brady Eidson

Comment 16 2020-07-09 13:19:29 PDT

Created attachment 403910 [details] Patch

Brady Eidson

Comment 17 2020-07-09 13:29:00 PDT

This is intolerable. The IOKitSPI.h header is bizarrely kinda cross platform but not really. Forget it. Doing something else.

Brady Eidson

Comment 18 2020-07-09 13:37:58 PDT

Created attachment 403912 [details] Patch

Brady Eidson

Comment 19 2020-07-09 14:22:36 PDT

Created attachment 403919 [details] Patch

Brady Eidson

Comment 20 2020-07-09 14:31:25 PDT

Created attachment 403920 [details] Patch

Tim Horton

Comment 21 2020-07-09 15:54:40 PDT

Comment on attachment 403920 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403920&action=review > Source/WebCore/platform/gamepad/cocoa/GameControllerGamepadProvider.h:59 > + void makeInvisibileGamepadsVisible(); s.p. invisibile

Brady Eidson

Comment 22 2020-07-09 17:41:31 PDT

Created attachment 403936 [details] PFL

EWS

Comment 23 2020-07-09 18:28:02 PDT

Committed r264207: <https://trac.webkit.org/changeset/264207> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403936 [details].

Note You need to log in before you can comment on or make changes to this bug.