Bug 214063

Summary: Modernize FindOptions IPC code
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cdumez, cgarcia, darin, ddkilzer, ews-watchlist, gustavo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Alex Christensen 2020-07-07 15:59:42 PDT 
Modernize FindOptions IPC code
Comment 1 Alex Christensen 2020-07-07 16:00:42 PDT 
Created attachment 403738 [details]
Patch
Comment 2 Darin Adler 2020-07-07 16:04:25 PDT 
Comment on attachment 403738 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403738&action=review

> Source/WebKit/WebProcess/WebPage/FindController.cpp:299
> +    if (!options.contains(FindOptions::ShowOverlay)
> +        && !options.contains(FindOptions::ShowFindIndicator))

Like it better as a long line.
Comment 3 Alex Christensen 2020-07-07 16:06:26 PDT 
Created attachment 403739 [details]
Patch
Comment 4 EWS 2020-07-07 16:39:57 PDT 
Patch 403739 does not build
Comment 5 Alex Christensen 2020-07-07 17:29:48 PDT 
Created attachment 403745 [details]
Patch
Comment 6 EWS Watchlist 2020-07-07 17:30:35 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 7 Alex Christensen 2020-07-07 17:45:11 PDT 
Created attachment 403746 [details]
Patch
Comment 8 Alex Christensen 2020-07-07 18:16:15 PDT 
Created attachment 403749 [details]
Patch
Comment 9 EWS 2020-07-07 19:28:51 PDT 
Committed r264055: <https://trac.webkit.org/changeset/264055>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403749 [details].
Comment 10 Radar WebKit Bug Importer 2020-07-07 19:29:17 PDT 
<rdar://problem/65204503>