Bug 214063

Summary: Modernize FindOptions IPC code
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cdumez, cgarcia, darin, ddkilzer, ews-watchlist, gustavo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2020-07-07 15:59:42 PDT
Modernize FindOptions IPC code
Attachments
Patch (30.20 KB, patch)
2020-07-07 16:00 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (30.19 KB, patch)
2020-07-07 16:06 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (36.71 KB, patch)
2020-07-07 17:29 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (36.87 KB, patch)
2020-07-07 17:45 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (37.74 KB, patch)
2020-07-07 18:16 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-07-07 16:00:42 PDT
Created attachment 403738 [details] Patch
Darin Adler
Comment 2 2020-07-07 16:04:25 PDT
Comment on attachment 403738 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403738&action=review > Source/WebKit/WebProcess/WebPage/FindController.cpp:299 > + if (!options.contains(FindOptions::ShowOverlay) > + && !options.contains(FindOptions::ShowFindIndicator)) Like it better as a long line.
Alex Christensen
Comment 3 2020-07-07 16:06:26 PDT
Created attachment 403739 [details] Patch
EWS
Comment 4 2020-07-07 16:39:57 PDT
Patch 403739 does not build
Alex Christensen
Comment 5 2020-07-07 17:29:48 PDT
Created attachment 403745 [details] Patch
EWS Watchlist
Comment 6 2020-07-07 17:30:35 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Alex Christensen
Comment 7 2020-07-07 17:45:11 PDT
Created attachment 403746 [details] Patch
Alex Christensen
Comment 8 2020-07-07 18:16:15 PDT
Created attachment 403749 [details] Patch
EWS
Comment 9 2020-07-07 19:28:51 PDT
Committed r264055: <https://trac.webkit.org/changeset/264055> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403749 [details].
Radar WebKit Bug Importer
Comment 10 2020-07-07 19:29:17 PDT
<rdar://problem/65204503>
Note You need to log in before you can comment on or make changes to this bug.