Bug 213975

Summary: Use RenderObject::positionForPoint instead of hit testing the entire view in closestEditablePositionInElementForAbsolutePoint
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebCore Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, mifenton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=210939
Attachments:
Description Flags
Patch none

Daniel Bates
Reported 2020-07-05 12:36:03 PDT
This bug is following up on my comment bug 210939, comment 3. closestEditablePositionInElementForAbsolutePoint can be made more efficient by using RenderObject::positionForPoint to hit test the target element's renderer instead of doing this indirectly by way of hit testing the entire RenderView.
Attachments
Patch (2.34 KB, patch)
2020-07-05 12:52 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2020-07-05 12:52:08 PDT
Created attachment 403561 [details] Patch
Daniel Bates
Comment 2 2020-07-06 09:27:52 PDT
Comment on attachment 403561 [details] Patch Clearing flags on attachment: 403561 Committed r263969: <https://trac.webkit.org/changeset/263969>
Daniel Bates
Comment 3 2020-07-06 09:27:54 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2020-07-06 09:28:14 PDT
<rdar://problem/65134809>
Note You need to log in before you can comment on or make changes to this bug.