Bug 213931

Summary: Add "-Wliteral-conversion" warning to Xcode based builds and fix the issues it finds
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, darin, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Sam Weinig
Reported 2020-07-03 11:21:48 PDT
Add "-Wliteral-conversion" warning to Xcode based builds and fix the issues it finds
Attachments
Patch (17.84 KB, patch)
2020-07-03 11:25 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2020-07-03 11:25:42 PDT
Created attachment 403471 [details] Patch
EWS
Comment 2 2020-07-03 13:31:02 PDT
Committed r263906: <https://trac.webkit.org/changeset/263906> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403471 [details].
Radar WebKit Bug Importer
Comment 3 2020-07-03 13:32:19 PDT
<rdar://problem/65082658>
Alexey Proskuryakov
Comment 4 2020-07-03 17:12:01 PDT
I see that two of the three issues fixed are about debug background, but us the remaining one untestable?
Darin Adler
Comment 5 2020-07-03 21:43:42 PDT
(In reply to Alexey Proskuryakov from comment #4) > I see that two of the three issues fixed are about debug background, but us > the remaining one untestable? All three are about debug background.
Note You need to log in before you can comment on or make changes to this bug.