Summary: | [WebAuthn] Cache the PIN to improve NFC user experience | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | login Llama <loginllama> | ||||||||
Component: | WebCore Misc. | Assignee: | Jiewen Tan <jiewen_tan> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bfulgham, jiewen_tan, loginllama, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | Safari Technology Preview | ||||||||||
Hardware: | iPhone / iPad | ||||||||||
OS: | Other | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 181943 | ||||||||||
Attachments: |
|
Description
login Llama
2020-07-02 14:38:44 PDT
Created attachment 404328 [details]
Patch
Comment on attachment 404328 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404328&action=review > Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:292 > + m_pendingRequestData.cachedPin = pin; Oops, forgot to use the weak pointer. Created attachment 404364 [details]
Patch
Comment on attachment 404364 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404364&action=review r=me > Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:284 > + // issue. The probability of the issue, however, should be rare. I think this is pretty well documented in the Bugzilla. I would suggest a shorter note: // Cache the PIN to improve NFC user experience so that a momentary movement of the NFC key away from the scanner doesn't force the PIN entry to be re-entered. Question: Should this have some kind of timeout to clear it if some period of time passes? That might be a reasonable followup patch if you think it's needed. I don't think it's required here. Comment on attachment 404364 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404364&action=review Thanks Brent for r+ this patch. >> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:284 >> + // issue. The probability of the issue, however, should be rare. > > I think this is pretty well documented in the Bugzilla. > > I would suggest a shorter note: > > // Cache the PIN to improve NFC user experience so that a momentary movement of the NFC key away from the scanner doesn't force the PIN entry to be re-entered. > > Question: Should this have some kind of timeout to clear it if some period of time passes? > > That might be a reasonable followup patch if you think it's needed. I don't think it's required here. Fixed. For the timer, I'm not sure. The API has a global timeout timer which has a maximum value of 120s. After, the whole request will be cancelled. I guess it's enough? Created attachment 404603 [details]
Patch for landing
Committed r264543: <https://trac.webkit.org/changeset/264543> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404603 [details]. *** Bug 214849 has been marked as a duplicate of this bug. *** |