Bug 213876

Summary: REGRESSION(r263625): run-minibrowser fails on mac
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: Tools / TestsAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, glenn, jbedard, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Philippe Normand
Reported 2020-07-02 01:07:43 PDT
$ Tools/Scripts/run-minibrowser --mac AttributeError raised: 'list' object has no attribute 'startswith' Traceback (most recent call last): File "/Users/philn/WebKit/Tools/Scripts/webkitpy/minibrowser/run_webkit_app.py", line 59, in main return port.run_minibrowser(args) File "/Users/philn/WebKit/Tools/Scripts/webkitpy/port/base.py", line 1372, in run_minibrowser return self._run_script(["old-run-minibrowser", ] + args) File "/Users/philn/WebKit/Tools/Scripts/webkitpy/port/base.py", line 1486, in _run_script run_script_command = [self.path_to_script(script_name)] File "/Users/philn/WebKit/Tools/Scripts/webkitpy/port/base.py", line 717, in path_to_script return self._webkit_finder.path_to_script(script_name) File "/Users/philn/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py", line 64, in path_to_script return self._filesystem.join("Tools", "Scripts", script_name) File "/Users/philn/WebKit/Tools/Scripts/webkitpy/common/system/filesystem.py", line 162, in join return os.path.join(*comps) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/posixpath.py", line 68, in join if b.startswith('/'): AttributeError: 'list' object has no attribute 'startswith'
Attachments
Patch (1.35 KB, patch)
2020-07-02 01:10 PDT, Philippe Normand
no flags
Philippe Normand
Comment 1 2020-07-02 01:10:58 PDT
EWS
Comment 2 2020-07-02 09:31:50 PDT
Committed r263848: <https://trac.webkit.org/changeset/263848> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403351 [details].
Radar WebKit Bug Importer
Comment 3 2020-07-02 09:32:19 PDT
Note You need to log in before you can comment on or make changes to this bug.