Summary: | [iOS] Crash under WebKit::WebPage::getFocusedElementInformation() | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||
Component: | New Bugs | Assignee: | Antoine Quint <graouts> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | darin, graouts, webkit-bug-importer, wenson_hsieh | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Antoine Quint
2020-06-30 08:07:22 PDT
Created attachment 403201 [details]
Patch
Committed r263752: <https://trac.webkit.org/changeset/263752> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403201 [details]. Comment on attachment 403201 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403201&action=review > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:3108 > + for (unsigned index = 0; index < labels->length(); ++index) { > + if (is<Element>(labels->item(index)) && labels->item(index)->renderer()) > + associatedLabels.append(downcast<Element>(*labels->item(index))); > + } Not new to this patch: Is NodeList::item efficient enough that we should call it 3 times rather than putting the result into a local? |