Bug 213793

Summary: REGRESSION (r207558): [Mac] Context clicks on links sometimes result in navigations
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, cgarcia, ggaren, megan_gardner, opendarwin, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 163292    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Andy Estes
Reported 2020-06-30 07:01:32 PDT
[Mac] Context clicks on links sometimes result in navigations
Attachments
Patch (10.31 KB, patch)
2020-06-30 07:01 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (60.80 KB, patch)
2020-07-03 00:13 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (59.86 KB, patch)
2020-07-03 00:20 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (62.18 KB, patch)
2020-07-07 22:46 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (60.96 KB, patch)
2020-07-08 10:05 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2020-06-30 07:01:51 PDT Comment hidden (obsolete)
Andy Estes
Comment 2 2020-07-02 22:19:40 PDT
rdar://problem/64294015
Andy Estes
Comment 3 2020-07-03 00:13:50 PDT Comment hidden (obsolete)
Andy Estes
Comment 4 2020-07-03 00:20:21 PDT Comment hidden (obsolete)
Andy Estes
Comment 5 2020-07-07 22:46:23 PDT
Created attachment 403759 [details] Patch
Tim Horton
Comment 6 2020-07-07 23:29:35 PDT
Comment on attachment 403759 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403759&action=review Delightful! > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:62 > + <CommandLineArguments> > + <CommandLineArgument > + argument = "--gtest_filter=&quot;WebKit.ContextMenuControlClick&quot;" > + isEnabled = "YES"> > + </CommandLineArgument> > + </CommandLineArguments> > + <AdditionalOptions> > + </AdditionalOptions> Please revert this part!
Andy Estes
Comment 7 2020-07-08 09:33:08 PDT
(In reply to Tim Horton from comment #6) > Comment on attachment 403759 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=403759&action=review > > Delightful! ☺️ > > > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:62 > > + <CommandLineArguments> > > + <CommandLineArgument > > + argument = "--gtest_filter=&quot;WebKit.ContextMenuControlClick&quot;" > > + isEnabled = "YES"> > > + </CommandLineArgument> > > + </CommandLineArguments> > > + <AdditionalOptions> > > + </AdditionalOptions> > > Please revert this part! 😬
Andy Estes
Comment 8 2020-07-08 10:05:52 PDT
Created attachment 403793 [details] Patch
EWS
Comment 9 2020-07-08 10:44:01 PDT
Committed r264113: <https://trac.webkit.org/changeset/264113> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403793 [details].
Note You need to log in before you can comment on or make changes to this bug.