Bug 213681

Summary: Fix missing exception check in createIDBKeyFromValue().
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: WebCore Misc.Assignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, beidson, cdumez, ews-watchlist, ggaren, jsbell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
mark.lam: review-
proposed patch.
cdumez: review+
patch for landing. none

Mark Lam
Reported 2020-06-27 10:04:15 PDT
<rdar://problem/64804893>
Attachments
proposed patch. (18.51 KB, patch)
2020-06-27 10:11 PDT, Mark Lam 		mark.lam: review-
DetailsFormatted DiffDiff
proposed patch. (20.52 KB, patch)
2020-06-27 10:27 PDT, Mark Lam 		cdumez: review+
DetailsFormatted DiffDiff
patch for landing. (20.52 KB, patch)
2020-06-27 11:02 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2020-06-27 10:11:46 PDT
Created attachment 402962 [details] proposed patch.
Mark Lam
Comment 2 2020-06-27 10:15:45 PDT
Comment on attachment 402962 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=402962&action=review > Source/WebCore/bridge/objc/WebScriptObject.mm:286 > + bool isSafe = BindingSecurity::shouldAllowAccessToDOMWindow(_private->originRootObject->globalObject(), target->wrapped()); Will remove extra space.
Mark Lam
Comment 3 2020-06-27 10:27:06 PDT
Created attachment 402963 [details] proposed patch.
Chris Dumez
Comment 4 2020-06-27 10:42:56 PDT
Comment on attachment 402963 [details] proposed patch. r=me if the bots are happy
Mark Lam
Comment 5 2020-06-27 10:57:05 PDT
Comment on attachment 402963 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=402963&action=review > Source/WebCore/bridge/objc/WebScriptObject.mm:287 > + bool isSafe = BindingSecurity::shouldAllowAccessToDOMWindow(_private->originRootObject->globalObject(), target->wrapped()); > + CLEAR_AND_RETURN_IF_EXCEPTION(scope, false); This call to BindingSecurity::shouldAllowAccessToDOMWindow() will never throw because it uses a default argument SecurityReportingOption = LogSecurityError. I'll change this CLEAR_AND_RETURN_IF_EXCEPTION to an EXCEPTION_ASSERT_UNUSED to assert that no exception is thrown.
Mark Lam
Comment 6 2020-06-27 11:02:35 PDT
Created attachment 402966 [details] patch for landing. Thanks for the review.
EWS
Comment 7 2020-06-27 15:14:09 PDT
Committed r263628: <https://trac.webkit.org/changeset/263628> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402966 [details].
Note You need to log in before you can comment on or make changes to this bug.