Bug 213661 – Web Inspector: Canvas: show an error message if unable to fetch shader source

• Component: Web Inspector
• Status: RESOLVED FIXED

[Devin Rousso]

.

[Devin Rousso]

Created attachment 402908 [details]
Patch

[Blaze Burg]

Comment on attachment 402908 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402908&action=review

> Source/WebInspectorUI/UserInterface/Views/ShaderProgramContentView.js:253
> +        if (!this.didInitialLayout) {

Will this code path ever be taken on subsequent refreshes? If not, how does spinnerContainer get recreated?

[Devin Rousso]

Comment on attachment 402908 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402908&action=review

>> Source/WebInspectorUI/UserInterface/Views/ShaderProgramContentView.js:253
>> +        if (!this.didInitialLayout) {
> 
> Will this code path ever be taken on subsequent refreshes? If not, how does spinnerContainer get recreated?

No, and that's intentional.  I think it's a somewhat reasonable claim that "if a shader successfully loads once, it'll likely to successfully load again" (and the same is true for the error case).  Yes, it's totally possible for a shader to be destroyed in between two fetches, but I don't think it's gonna be that common.  Because of this, we don't want to recreate the spinner each time we fetch as we'd likely see a brief flash from "old content"->"spinner"->"new content" (which is likely the exact same as "old content").  So we only show the spinner for the first fetch as there was no "old content".

[Blaze Burg]

Comment on attachment 402908 [details]
Patch

r=me

[EWS]

Committed r264045: <https://trac.webkit.org/changeset/264045>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402908 [details].

[Radar WebKit Bug Importer]

<rdar://problem/65196517>