Summary: | [GTK][WPE] Fix the matching of an empty value in getCgroupControllerPath() when only cgroupsV2 hierarchy is found | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pablo Saavedra <psaavedra> | ||||||
Component: | WebKitGTK | Assignee: | Pablo Saavedra <psaavedra> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aperez, bugs-noreply, clopez, mcatanzaro, pnormand | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Pablo Saavedra
2020-06-26 08:20:59 PDT
Created attachment 402865 [details]
patch
Comment on attachment 402865 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=402865&action=review > Source/WebKit/UIProcess/linux/MemoryPressureMonitor.cpp:220 > + // cgroupv2 You can remove this comment because the comparisong with the CGROUP_V2_HIERARCHY constant in the line right above is self-explanatory—which is why we like using constants with meaningful names, of course :) Created attachment 402900 [details]
patch
(In reply to Adrian Perez from comment #2) > Comment on attachment 402865 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=402865&action=review > > > Source/WebKit/UIProcess/linux/MemoryPressureMonitor.cpp:220 > > + // cgroupv2 > > You can remove this comment because the comparisong with > the CGROUP_V2_HIERARCHY constant in the line right above > is self-explanatory—which is why we like using constants > with meaningful names, of course :) done. Committed r263589: <https://trac.webkit.org/changeset/263589> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402900 [details]. Debug build fixed in https://trac.webkit.org/changeset/263632/webkit ... |