Bug 213626

Summary: REGRESSION(r256166, r260596) WKNavigationAction.request.allHTTPHeaderFields needs to contain User-Agent and Accept
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, ews-watchlist, japhet, rwlbuis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 207441, 209587    
Attachments:
Description Flags
Patch
none
Patch none

Description Alex Christensen 2020-06-25 16:10:06 PDT
REGRESSION(r256166, r260596) WKNavigationAction.request.allHTTPHeaderFields needs to contain User-Agent and Accept
Comment 1 Alex Christensen 2020-06-25 16:14:51 PDT
Created attachment 402824 [details]
Patch
Comment 2 Alex Christensen 2020-06-25 16:14:54 PDT
<rdar://problem/62374208>
Comment 3 Alex Christensen 2020-06-25 16:25:23 PDT
Created attachment 402826 [details]
Patch
Comment 4 Darin Adler 2020-06-25 16:55:38 PDT
Comment on attachment 402826 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402826&action=review

> Source/WebCore/ChangeLog:10
> +        Those two revisions seemed to just subtly move things around, but they caused API-breaking changes that caused real problems.
> +        This effectively reverts the parts of those changes that caused the breakages.

The revisions were not supposed to move things around. They were supposed to remove unnecessary things.

Seems now that for the Cocoa API they were necessary things. Would be nice if there was a way to restore that behavior without affecting things other than the Cocoa API.
Comment 5 EWS 2020-06-25 18:03:29 PDT
Committed r263548: <https://trac.webkit.org/changeset/263548>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402826 [details].