Bug 213585 – Running spellcheck on https://developer.apple.com/forums/thread/650317 hangs the web process

• Component: HTML Editing
• Status: RESOLVED FIXED

[Wenson Hsieh]

Steps (macOS):
1. Load https://developer.apple.com/forums/thread/650317
2. Click "Reply to this question"
   (Sign in with an Apple ID if needed)
4. Focus the comment box
5. Press CMD+; to trigger spellchecking.

The web content process hangs indefinitely as a result.

[Wenson Hsieh]

<rdar://problem/64681632>

[Wenson Hsieh]

Created attachment 402703 [details]
Patch

[Darin Adler]

Comment on attachment 402703 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402703&action=review

> Source/WebCore/testing/Internals.idl:383
> +    void advanceToNextMisspelling();

How can this be unconditional if the declaration in the .h file is inside an #if?

[Wenson Hsieh]

(In reply to Darin Adler from comment #3)
> Comment on attachment 402703 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=402703&action=review
> 
> > Source/WebCore/testing/Internals.idl:383
> > +    void advanceToNextMisspelling();
> 
> How can this be unconditional if the declaration in the .h file is inside an
> #if?

Indeed, this breaks the IOS_FAMILY build 😅. Trying to fix it now.

[Wenson Hsieh]

Created attachment 402705 [details]
Fix IOS_FAMILY build

[Wenson Hsieh]

Comment on attachment 402705 [details]
Fix IOS_FAMILY build

Thanks for the review!

[EWS]

Committed r263499: <https://trac.webkit.org/changeset/263499>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402705 [details].