Summary: | [WinCairo] Cannot build without resource load statistics | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Stephan Szabo <stephan.szabo> | ||||||
Component: | WebKit Misc. | Assignee: | Stephan Szabo <stephan.szabo> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, aperez, clopez, don.olmstead, webkit-bug-importer, youennf | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Stephan Szabo
2020-06-23 14:39:42 PDT
Created attachment 402594 [details]
Patch
I'm not sure if just using the old code in the not resource load statistics enabled case is the best option but it gets past the compile-time errors.
Comment on attachment 402594 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402594&action=review > Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp:75 > +#if ENABLE(RESOURCE_LOAD_STATISTICS) WKWebsiteDataStoreRemoveITPDataForDomain should probably just do nothing or immediately call the callback if RESOURCE_LOAD_STATISTICS is not enabled, because there's nothing to do. > Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1013 > +#if ENABLE(RESOURCE_LOAD_STATISTICS) Ditto. I think it's ok to just do nothing here if RESOURCE_LOAD_STATISTICS is not enabled. Created attachment 402743 [details]
Patch
Updated to call the callback immediately in the API case and to do nothing in the other when the flag isn't set.
Committed r263568: <https://trac.webkit.org/changeset/263568> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402743 [details]. |