Bug 21352

Summary: Clean up how tracking of code features is done in the parser a bit
Product: WebKit Reporter: Maciej Stachowiak <mjs>
Component: JavaScriptCoreAssignee: Maciej Stachowiak <mjs>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
cleanup patch zwarich: review+

Maciej Stachowiak
Reported 2008-10-03 16:58:33 PDT
Clean up how tracking of code features is done in the parser a bit.
Attachments
cleanup patch (133.64 KB, patch)
2008-10-03 16:59 PDT, Maciej Stachowiak 		zwarich: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Maciej Stachowiak
Comment 1 2008-10-03 16:59:06 PDT
Created attachment 24074 [details] cleanup patch
Cameron Zwarich (cpst)
Comment 2 2008-10-03 17:09:38 PDT
Comment on attachment 24074 [details] cleanup patch > static ProgramNode* create(JSGlobalData*, SourceElements*, VarStack*, FunctionStack*, const SourceCode&, CodeFeatures featureso, int numConstants) JSC_FAST_CALL; You should change 'featureso' to 'features', or better yet, remove the name of the CodeFeatures parameter in prototypes. Other than that, r=me assuming it passes tests.
Cameron Zwarich (cpst)
Comment 3 2008-10-04 08:59:04 PDT
Landed in r37275.
Note You need to log in before you can comment on or make changes to this bug.