Bug 213517 – [ macOS ] fullscreen/video-inside-flex-item.html is a flaky failure

• Component: New Bugs
• Status: RESOLVED FIXED

[Karl Rackler]

fullscreen/video-inside-flex-item.html

Description: 
This test is flaky failing on macOS.  It does seem to be passing on wk2 release.  It has been flaky failing since introduced.
Introduced here: https://trac.webkit.org/changeset/263389/webkit

History: 
https://results.webkit.org/?suite=layout-tests&test=fullscreen%2Fvideo-inside-flex-item.html&platform=ios&platform=mac

Diff: 
--- /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/fullscreen/video-inside-flex-item-expected.txt
+++ /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/fullscreen/video-inside-flex-item-actual.txt
@@ -2,7 +2,7 @@
 EVENT(webkitfullscreenchange)
 EXPECTED (800 == '800') OK
 EVENT(webkitfullscreenchange)
-EXPECTED (300 == '300') OK
-EXPECTED (150 == '150') OK
+EXPECTED (320 == '300'), OBSERVED '320' FAIL
+EXPECTED (240 == '150'), OBSERVED '240' FAIL
 END OF TEST

[Radar WebKit Bug Importer]

<rdar://problem/64643289>

[Karl Rackler]

Created attachment 402564 [details]
Patch

[Sergio Villar Senin]

I think in this case you should create specific expectations for the macos/ios failing configurations.

[Truitt Savell]

(In reply to Sergio Villar Senin from comment #3)
> I think in this case you should create specific expectations for the
> macos/ios failing configurations.

In this case the test would be marked to pass on Mac WK2 Release only. This doesn't seem like an effective test right now if it only functions for one specific configuration.

[Simon Fraser (smfr)]

Full results:

https://results.webkit.org/?suite=layout-tests&test=fullscreen%2Fvideo-inside-flex-item.html

So the test flakes on macOS WK1 Release, always fails on WK1 Debug, always passes on W2 Release, always fails on WK2 Debug.

Sergio, there's a timing issue with this test, please investigate.

[Sergio Villar Senin]

(In reply to Simon Fraser (smfr) from comment #5)
> Full results:
> 
> https://results.webkit.org/?suite=layout-tests&test=fullscreen%2Fvideo-
> inside-flex-item.html
> 
> So the test flakes on macOS WK1 Release, always fails on WK1 Debug, always
> passes on W2 Release, always fails on WK2 Debug.
> 
> Sergio, there's a timing issue with this test, please investigate.

Sure, I'll take a look.

[Sergio Villar Senin]

Created attachment 402581 [details]
Patch

[EWS]

Committed r263436: <https://trac.webkit.org/changeset/263436>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402581 [details].

[Ryan Haddad]

The test is still failing:
--- /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/fullscreen/video-inside-flex-item-expected.txt
+++ /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/fullscreen/video-inside-flex-item-actual.txt
@@ -2,7 +2,7 @@
 EVENT(webkitfullscreenchange)
 TEST(video.clientWidth == document.body.clientWidth) OK
 EVENT(webkitfullscreenchange)
-TEST(video.clientWidth == oldVideoWidth) OK
-TEST(video.clientHeight == oldVideoHeight) OK
+TEST(video.clientWidth == oldVideoWidth) FAIL
+TEST(video.clientHeight == oldVideoHeight) FAIL
 END OF TEST

[Ryan Haddad]

Reopening since this isn't fixed.

[Sergio Villar Senin]

(In reply to Ryan Haddad from comment #10)
> Reopening since this isn't fixed.

It's indeed failing on Debug, I'll come up with something soon.

[Sergio Villar Senin]

(In reply to Ryan Haddad from comment #10)
> Reopening since this isn't fixed.

I've submitted a patch to bug 213549 to fix this issue. It's working fine in Mac debug for me locally.

[Sergio Villar Senin]

Fixed in bug 213549