Bug 213497

Summary:

Use AVRoutePickerView when available for choosing AirPlay devices

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, ews-watchlist, glenn, jer.noble, philipj, sergio, tsavell, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Build fix	none
Another build fix	none
Patch	none
Patch	none

Eric Carlson

Reported 2020-06-22 17:10:54 PDT

Use AVRoutePickerView when available for choosing AirPlay devices

Attachments
Patch (74.12 KB, patch) 2020-07-15 16:51 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
Patch (76.11 KB, patch) 2020-07-16 09:29 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
Patch (78.60 KB, patch) 2020-07-16 10:49 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
Build fix (3.57 KB, patch) 2020-07-16 14:35 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
Another build fix (2.02 KB, patch) 2020-07-16 17:43 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
Patch (80.82 KB, patch) 2020-07-20 12:44 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
Patch (80.92 KB, patch) 2020-07-20 15:46 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2020-06-23 10:48:38 PDT

*** Bug 213496 has been marked as a duplicate of this bug. ***

Eric Carlson

Comment 2 2020-06-23 13:37:04 PDT

<rdar://problem/58610662>

Eric Carlson

Comment 3 2020-07-15 16:51:17 PDT

Created attachment 404405 [details] Patch

Jer Noble

Comment 4 2020-07-16 09:16:04 PDT

Comment on attachment 404405 [details] Patch r=me once the bots are happy.

Eric Carlson

Comment 5 2020-07-16 09:29:12 PDT

Created attachment 404449 [details] Patch

Eric Carlson

Comment 6 2020-07-16 10:49:12 PDT

Created attachment 404464 [details] Patch

Eric Carlson

Comment 7 2020-07-16 13:47:42 PDT

Comment on attachment 404464 [details] Patch The WK1 audio and accessibility test failures are unrelated.

EWS

Comment 8 2020-07-16 13:52:40 PDT

Committed r264477: <https://trac.webkit.org/changeset/264477> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404464 [details].

Eric Carlson

Comment 9 2020-07-16 14:35:30 PDT

Reopening to attach new patch.

Eric Carlson

Comment 10 2020-07-16 14:35:30 PDT

Created attachment 404485 [details] Build fix

EWS

Comment 11 2020-07-16 15:25:33 PDT

Committed r264482: <https://trac.webkit.org/changeset/264482> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404485 [details].

Eric Carlson

Comment 12 2020-07-16 17:43:06 PDT

Reopening to attach new patch.

Eric Carlson

Comment 13 2020-07-16 17:43:07 PDT

Created attachment 404503 [details] Another build fix

EWS

Comment 14 2020-07-16 18:37:24 PDT

Committed r264493: <https://trac.webkit.org/changeset/264493> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404503 [details].

Truitt Savell

Comment 15 2020-07-17 09:05:58 PDT

Reverted r264493 for reason: Part of an attempted fix for the build Committed r264513: <https://trac.webkit.org/changeset/264513>

Truitt Savell

Comment 16 2020-07-17 09:07:20 PDT

Reverted r264482 for reason: Part of an attempted fix for the build Committed r264514: <https://trac.webkit.org/changeset/264514>

Truitt Savell

Comment 17 2020-07-17 09:10:40 PDT

Reverted r264477 for reason: Broke the internal build Committed r264515: <https://trac.webkit.org/changeset/264515>

Eric Carlson

Comment 18 2020-07-20 12:44:31 PDT

Created attachment 404745 [details] Patch

Eric Carlson

Comment 19 2020-07-20 15:46:49 PDT

Created attachment 404771 [details] Patch

EWS

Comment 20 2020-07-21 10:46:34 PDT

Committed r264663: <https://trac.webkit.org/changeset/264663> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404771 [details].

Note You need to log in before you can comment on or make changes to this bug.