Bug 213489

Summary: Remove WKkIsTranslated once our bots are updated to the needed SDK
Product: WebKit Reporter: Saam Barati <saam>
Component: Web Template FrameworkAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, mitz, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
thorton: review+
patch for landing none

Saam Barati
Reported 2020-06-22 15:23:02 PDT
...
Attachments
patch (7.07 KB, patch)
2020-06-23 11:09 PDT, Saam Barati 		thorton: review+
DetailsFormatted DiffDiff
patch for landing (7.04 KB, patch)
2020-06-23 11:15 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2020-06-22 15:47:15 PDT
Rather than using _COMM_PAGE_CPU_CAPABILITIES64, you should consider using the oah_is_current_process_translated SPI.
Saam Barati
Comment 2 2020-06-22 16:32:53 PDT
(In reply to mitz from comment #1) > Rather than using _COMM_PAGE_CPU_CAPABILITIES64, you should consider using > the oah_is_current_process_translated SPI. Will do
mitz
Comment 3 2020-06-23 08:53:33 PDT
(In reply to Saam Barati from comment #2) > (In reply to mitz from comment #1) > > Rather than using _COMM_PAGE_CPU_CAPABILITIES64, you should consider using > > the oah_is_current_process_translated SPI. > > Will do Better yet, use the public sysctl interface documented at <https://developer.apple.com/documentation/apple_silicon/about_the_rosetta_translation_environment>.
Saam Barati
Comment 4 2020-06-23 10:18:52 PDT
(In reply to mitz from comment #3) > (In reply to Saam Barati from comment #2) > > (In reply to mitz from comment #1) > > > Rather than using _COMM_PAGE_CPU_CAPABILITIES64, you should consider using > > > the oah_is_current_process_translated SPI. > > > > Will do > > Better yet, use the public sysctl interface documented at > <https://developer.apple.com/documentation/apple_silicon/ > about_the_rosetta_translation_environment>. 👍🏼
Saam Barati
Comment 5 2020-06-23 10:21:19 PDT
I think we can just make this change now if we're using the sysctl
Saam Barati
Comment 6 2020-06-23 11:09:58 PDT
Created attachment 402571 [details] patch
Saam Barati
Comment 7 2020-06-23 11:11:46 PDT
Comment on attachment 402571 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=402571&action=review > Source/WTF/wtf/TranslatedProcess.cpp:33 > +#include <wtf/DataLog.h> will remove
Tim Horton
Comment 8 2020-06-23 11:12:04 PDT
Comment on attachment 402571 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=402571&action=review > Source/WTF/wtf/TranslatedProcess.cpp:33 > +#include <wtf/DataLog.h> Why's this?
Saam Barati
Comment 9 2020-06-23 11:12:34 PDT
(In reply to Tim Horton from comment #8) > Comment on attachment 402571 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=402571&action=review > > > Source/WTF/wtf/TranslatedProcess.cpp:33 > > +#include <wtf/DataLog.h> > > Why's this? It was testing. Will remove
Saam Barati
Comment 10 2020-06-23 11:15:47 PDT
Created attachment 402572 [details] patch for landing
EWS
Comment 11 2020-06-23 13:11:41 PDT
Committed r263415: <https://trac.webkit.org/changeset/263415> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402572 [details].
Radar WebKit Bug Importer
Comment 12 2020-06-23 13:12:39 PDT
<rdar://problem/64660056>
Note You need to log in before you can comment on or make changes to this bug.