Bug 213386
| Summary: | [GTK] fast/images/low-memory-decode.html is timing out | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Diego Pino <dpino> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | csaavedra |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=247715 | ||
Diego Pino
Unexpected flakiness: text-only failures (1)
fast/images/low-memory-decode.html [ Failure Timeout Pass ]
It seems the test has been flaky since a long time ago.
Diff: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r263263%20(14157)/fast/images/low-memory-decode-diff.txt
--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/images/low-memory-decode-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/images/low-memory-decode-actual.txt
@@ -1,2 +1,2 @@
-Image decode count: 1
+Image decode count: 2
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Diego Pino
This test is constantly timing out:
https://build.webkit.org/results/GTK-Linux-64-bit-Release-Tests/r278650%20%282224%29/fast/images/low-memory-decode-diff.txt
--- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/fast/images/low-memory-decode-expected.txt
+++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/fast/images/low-memory-decode-actual.txt
@@ -1,2 +1,2 @@
-Image decode count: 1
+FAIL: Timed out waiting for notifyDone to be called
Gardened in r278654.
Claudio Saavedra
I see the test is now crashing instead of timing out in the GTK bots. However, for me it's timing out locally. The reason for the timeout is that tryFinish() does not always call testRunner.notifyDone(), so the test is forever waiting for it. IMO the test should always call test.runnerNotifyDone() and internals.endSimulatedMemoryPressure(), regardless of whether the image was decoded correctly or not. So I will fix that in a separate bug (because the test is still failing after fixing that).
Claudio Saavedra
The crash was fixed with https://bugs.webkit.org/show_bug.cgi?id=247727 but the test still timeouts in GTK. Confirmed with Antti that the test is correct, I made the wrong assumption earlire.
Diego Pino
This test is passing now:
https://results.webkit.org/?platform=GTK&platform=WPE&suite=layout-tests&test=fast%2Fimages%2Flow-memory-decode.html
Closing bug.