Summary: | [GStreamer] imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-immediately.https.html is a flaky crash | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Diego Pino <dpino> | ||||||||
Component: | Media | Assignee: | Xabier Rodríguez Calvar <calvaris> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | calvaris, cgarcia, eric.carlson, ews-watchlist, glenn, gustavo, jer.noble, menard, philipj, pnormand, sergio, vjaquez, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Diego Pino
2020-06-19 09:55:24 PDT
Created attachment 402958 [details]
Patch
Comment on attachment 402958 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402958&action=review Can you remove the test flakyness from the TestExpectations? > Source/WebCore/platform/encryptedmedia/CDMProxy.h:225 > + m_cdmProxy->releaseDecryptionResources(); Are we sure m_cdmProxy is valid here? Comment on attachment 402958 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402958&action=review Other than this, any other comments to prevent r+? >> Source/WebCore/platform/encryptedmedia/CDMProxy.h:225 >> + m_cdmProxy->releaseDecryptionResources(); > > Are we sure m_cdmProxy is valid here? No, you're right, we aren't. It was like that before but this suffered some changes and I forgot to check that. I'll check for null. Created attachment 403049 [details]
Patch
Created attachment 403050 [details]
Patch
Committed r263658: <https://trac.webkit.org/changeset/263658> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403050 [details]. |